Add a new endpoint to unreserve a path #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthorner
force-pushed
the
add-unreserve-path-endpoint
branch
2 times, most recently
from
10e4845 to
90b8275
Compare
kevindew
approved these changes
Mar 15, 2019
| let(:request_body) { payload.to_json } | ||
|
|
||
| def do_request(body: request_body, headers: {}) | ||
| delete request_path, params: body, headers: headers |
There was a problem hiding this comment.
ooh TIL - did not realise request_path could be in scope here
| fail. | ||
| - If a path reservation exists for the supplied base_path but a different | ||
| publishing_app, the command will fail. | ||
|
|
spec/commands/unreserve_path_spec.rb
Outdated
|
|
||
| context "when the path is not owned by the app" do | ||
| it "returns an error" do | ||
| payload = { base_path: "/bar" } |
There was a problem hiding this comment.
This test looks a bit like it's testing what happens when a required parameter is missing rather than owned by a different app.
There was a problem hiding this comment.
Fair enough - I was being minimal. Amended :-).
benthorner
force-pushed
the
add-unreserve-path-endpoint
branch
from
90b8275 to
f0f7207
Compare
|
What's the motivation for this change? It would be good if you could add that to the commit message. |
This adds a new command to unreserve (destroy) a PathReservation, provided the reservation exists and matches the given publishing app. As we migrate formats from Whitehall to Content Publisher, users sometimes need to revert to Whitehall if certain features aren't available. Because Whitehall assumes it is authoritative for all paths in a format, we need to be able to cleanup the Publishing API in order for the user to re-create their content in Whitehall and re-use a path.
benthorner
force-pushed
the
add-unreserve-path-endpoint
branch
from
f0f7207 to
8014783
Compare
|
@cbaines sure, I've updated the commit - the Trello card on this PR should also give more context :-). |
Great, thanks. Scary, but still good to know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/6s9Bhzyj/632-delete-publishing-api-path-reservations-when-we-discard-drafts
This adds a new command to unreserve (destroy) a PathReservation,
provided the reservation exists and matches the given publishing app.