Add pub api unreserve path #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthorner
force-pushed
the
add-pub-api-unreserve-path
branch
2 times, most recently
from
7f9eb35 to
9fb68ca
Compare
added 2 commits
March 15, 2019 17:19
This adds a new method to the Pub API adapter to complement the new endpoint to unreserve a path in the Publishing API.
benthorner
force-pushed
the
add-pub-api-unreserve-path
branch
from
9fb68ca to
c7be09a
Compare
kevindew
reviewed
Mar 15, 2019
|
@kevindew this should be ready to review again now :-). |
1pretz1
reviewed
Mar 20, 2019
1pretz1
reviewed
Mar 20, 2019
1pretz1
reviewed
Mar 20, 2019
added 2 commits
March 20, 2019 11:41
This was introduced in 2e19c7a, but the referenced RFC has since been superceded, and it is now accepted to have a body in a DELETE request. https://tools.ietf.org/html/rfc7231#page-29
This reduces the amount of boilerplate we need to write when testing against this feature.
benthorner
force-pushed
the
add-pub-api-unreserve-path
branch
from
bb3e7b8 to
bc4eaa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/6s9Bhzyj/632-delete-publishing-api-path-reservations-when-we-discard-drafts
This complements the new Publishing API endpoint to unreserve a path (alphagov/publishing-api#1468).