Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in Cloud Foundry v3 API #236

Merged
merged 8 commits into from
Aug 1, 2019
Merged

Add in Cloud Foundry v3 API #236

merged 8 commits into from
Aug 1, 2019

Conversation

jonathanglassman
Copy link
Contributor

@jonathanglassman jonathanglassman commented Jul 24, 2019

What

Added in content on the Cloud Foundry v3 API:

  • add recreating the network policy for deploying a private app
  • add content on deploying a static HTML page using the CF API v3
  • rename content on deploying a static HTML page to deploying a static HTML page using the CF API v2
  • add warning on cf ssh command for v3 of CF API

How to review

Describe the steps required to test the changes.

  1. Preview the content locally (see README) and check that it renders as expected.
  2. Manually check that any removed or renamed anchor tags are not in use (linkchecker doesn't do this).
  3. Check that it fulfils https://www.pivotaltracker.com/story/show/165305947

Who can review

Anyone excluding Jon Glassman

@jonathanglassman jonathanglassman changed the title add in Cloud Foundry v3 API Add in Cloud Foundry v3 API Jul 25, 2019
Copy link
Contributor

@46bit 46bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks really good. I've left some suggestions but very open to feedback on them.

Copy link
Contributor

@46bit 46bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@whi-tw
Copy link
Member

whi-tw commented Jul 31, 2019

Just a comment to bring up the possible gotcha with sshing to a app pushed via the v3 API: cf ssh-code stops working.

@jonathanglassman
Copy link
Contributor Author

Passed 2i and merging

@jonathanglassman jonathanglassman merged commit 444fe6f into master Aug 1, 2019
@46bit 46bit deleted the cfapiv3 branch August 1, 2019 09:43
tlwr added a commit that referenced this pull request Aug 1, 2019
tlwr pushed a commit that referenced this pull request Aug 1, 2019
In this pull request #236
we added new documentation about the V3 API, but this PR also included
some single sign-on content (from #234) that has since been overwritten

This commit recommits the content which we care about.

Co-authored-by: Jon <[email protected]>
Co-authored-by: Toby <[email protected]>

Rename ssh.md to ssh.erb & add warning text v3 ssh
tlwr pushed a commit that referenced this pull request Aug 1, 2019
In this pull request #236
we added new documentation about the V3 API, but this PR also included
some single sign-on content (from #234) that has since been overwritten

This commit recommits the content which we care about.

Co-authored-by: Jon <[email protected]>
Co-authored-by: Toby <[email protected]>
tlwr pushed a commit that referenced this pull request Aug 1, 2019
Partially recommit changes from #236
kr8n3r added a commit that referenced this pull request Sep 15, 2021
Main one is govuk-tech-docs gem v2.4.3 which brings

- [#236: Fix search 'autocomplete' behaviour](alphagov/tech-docs-gem#236)
- [#203: Update vendored javascripts](alphagov/tech-docs-gem#203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants