-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in Cloud Foundry v3 API #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks really good. I've left some suggestions but very open to feedback on them.
Co-Authored-By: Richard Towers <[email protected]>
Co-Authored-By: Richard Towers <[email protected]>
Co-Authored-By: Richard Towers <[email protected]>
Co-Authored-By: Miki Mokrysz <[email protected]>
01dded4
to
4e95170
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Just a comment to bring up the possible gotcha with sshing to a app pushed via the v3 API: |
Passed 2i and merging |
In this pull request #236 we added new documentation about the V3 API, but this PR also included some single sign-on content (from #234) that has since been overwritten This commit recommits the content which we care about. Co-authored-by: Jon <[email protected]> Co-authored-by: Toby <[email protected]> Rename ssh.md to ssh.erb & add warning text v3 ssh
In this pull request #236 we added new documentation about the V3 API, but this PR also included some single sign-on content (from #234) that has since been overwritten This commit recommits the content which we care about. Co-authored-by: Jon <[email protected]> Co-authored-by: Toby <[email protected]>
Partially recommit changes from #236
Main one is govuk-tech-docs gem v2.4.3 which brings - [#236: Fix search 'autocomplete' behaviour](alphagov/tech-docs-gem#236) - [#203: Update vendored javascripts](alphagov/tech-docs-gem#203)
What
Added in content on the Cloud Foundry v3 API:
How to review
Describe the steps required to test the changes.
Who can review
Anyone excluding Jon Glassman