Single sign-on update #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| The email attached to your GOV.UK PaaS account must be the same as the email attached to your Google or Microsoft account. | ||
| You must have either a [Google](https://myaccount.google.com/intro) or [Microsoft](https://account.microsoft.com/account) email address to use single sign-on. The email address must be the same as the one you use to sign into your GOV.UK PaaS account. |
There was a problem hiding this comment.
The email address must be the same as the one you use to sign into your GOV.UK PaaS account.
Is this actually true? @tlwr?
There was a problem hiding this comment.
This used to be the case for Google
For Microsoft I do not think it is the case
I assume Google will no longer be the case after we enable it for everyone
There was a problem hiding this comment.
That's my understanding too. A bit confusing to have people use accounts with different emails, but I think it will be possible.
Maybe it's better to have this sentence in the docs, even if it's not technically true?
tlwr
pushed a commit
that referenced
this pull request
Aug 1, 2019
In this pull request #236 we added new documentation about the V3 API, but this PR also included some single sign-on content (from #234) that has since been overwritten This commit recommits the content which we care about. Co-authored-by: Jon <[email protected]> Co-authored-by: Toby <[email protected]> Rename ssh.md to ssh.erb & add warning text v3 ssh
tlwr
pushed a commit
that referenced
this pull request
Aug 1, 2019
In this pull request #236 we added new documentation about the V3 API, but this PR also included some single sign-on content (from #234) that has since been overwritten This commit recommits the content which we care about. Co-authored-by: Jon <[email protected]> Co-authored-by: Toby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The single sign-on function previously only worked for people in GDS with a GDS email address. It now works for everyone with a Google or Microsoft account. This updated content reflects this.
How to review
Describe the steps required to test the changes.
Who can review
Describe who can review the changes. Or more importantly, list the people
that can't review, because they worked on it.