Set the boolean disabled attribute consistently in the button component

[36degrees]

Remove the value from the attribute so that we're setting boolean HTML attributes consistently across all components – matching what we're doing in the radios, checkboxes and select components.

Re-enable the 'attribute-boolean-style' rule so that we enforce this going forward.

Split out from #2828.

[36degrees]

As flagged in #2828 (comment), there are a few edge cases where this could be considered a breaking change.

Specifically, if a user is using getAttribute and relying on the value of the response either exactly matching the string 'disabled' or being truthy:

if ($button.getAttribute('disabled') == 'disabled') {
  // no longer works as getAttribute('disabled') on an element
  // with <button disabled> returns an empty string
}

if ($button.getAttribute('disabled')) {
  // no longer works as an empty string is falsey
}

Depending on how likely we think this scenario is, we could either:

• accept the risk and include the change in the next minor release
• consider making this change in the next major release
• close this PR and avoid making this change

[romaricpascal]

Another thing that the change may break besides app using JS to check if the button is disabled may be the fixtures for validating non JS implementations.

Rails outputs boolean attributes in the disabled="disabled" form, I believe. Through its button_tag helper, for example.

[colinrotherham]

Approving this based on a discussion we had yesterday 🙌

But we also flagged the HTML living standard in reference to whether this is a breaking change or not from #2830 (comment)

2.3.2 Boolean attributes
https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#boolean-attributes

They give three examples considered valid:

<label><input type=checkbox checked name=cheese disabled> Cheese</label>

<label><input type=checkbox checked=checked name=cheese disabled=disabled> Cheese</label>

<label><input type='checkbox' checked name=cheese disabled=""> Cheese</label>

Although it might be breaking, we've essentially switched from "valid" to "also valid" ✅

[querkmachine]

Presumably this can now be merged given 4.6.0 has gone out, conflict notwithstanding.

[36degrees]

I need to add a changelog entry as well.

[36degrees]

I've rebased to resolve the conflict and added a changelog entry.

[colinrotherham]

🎉