-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes for html-validate
(nested forms etc)
#3115
Conversation
We already have a wrapping `<form>` in `layout-example.njk`
Examples that don’t need a `<form>` wrapper can stay on the previous layout 1. Prevents nested `<form>` elements to fix #2609 2. Prevents unnecessary `<form>` element wrapping
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
95d210b
to
d540a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good but I don't quite understand the changes or the commit message for d540a4e – alphagov/govuk-frontend#2830 is part of v5 so that fix hasn't gone out yet?
Buttons are all fixed but still got a few `<fieldset hidden="">` remaining
@36degrees Ahh in that case, maybe we fixed them all here too? We have failures for Comes from where we pass an empty string into the attribute value: govuk-design-system/src/cookies.njk Lines 115 to 118 in 8821a80
Remember this? I'll update the example again |
d540a4e
to
a448bd6
Compare
Realised we don't have any examples of disabled buttons so I suspect the rule was always disabled because of the hidden attribute on fieldsets? 🤔 Anyway, the comment change still makes sense. |
@36degrees Great, thanks Yeah. Possibly just copied over from alphagov/govuk-frontend@500a02f |
PR to fix various issues flagged by
html-validate
which we've temporarily ignoredIssues now fixed
type="submit"
To fix "forms within forms" I've split our example layout in two:
Issues already fixed
Plus some issues had already been fixed so we can remove their rules:
disabled
attribute consistently in the button component govuk-frontend#2830I'll open a separate PR for cookie banner specific things