Add supergroup sections to taxonomy navigation #994

oscarwyatt · 2018-07-25T15:06:36Z

Adds guidance and regulation, and policy and engagement sections to the nav section at the footer of content pages.

Policy and engagement content:
- configured to get latest content
- shows public updated at date
- document type
Guidance and regulation
- retrieved by popularity (as determined by rummager)
- shows document type (but not date)

They're both displayed as lists of items rather than highlight boxes.

The content page will show this navigation if they are tagged to a live taxonomy, be rendered by this application and not be an HTML publication (and have results to show)

This PR is to get things generally close to the desired outcome and then we'll polish after testing and a further design review.

Examples:

You will need to have an extension like ModHeader installed in your browser to see the B Variant. The values should be:
Request Header Name: GOVUK-ABTest-ContentPagesNav
Request Header Value: B

Component guide for this PR:
https://government-frontend-pr-994.herokuapp.com/component-guide

vanitabarrett

I'd recommend squashing your commits into one and giving them slightly more descriptive messages so it's clear what's being changed

vanitabarrett · 2018-07-26T11:16:27Z

app/lib/services.rb

@@ -10,4 +11,8 @@ def self.content_store
      disable_cache: true,
    )
  end
+
+  def self.rummager


I think once you rebase you won't need this as it's already been added for the Services work

vanitabarrett · 2018-07-26T11:17:41Z

app/presenters/content_item_presenter.rb

@@ -71,6 +71,24 @@ def cache_control_public?
    !content_item.cache_control.private?
  end

+  def has_policy_and_engagement_links?


I think these should probably be moved out into policy_and_engagement.rb as it's specific to that. Same with policy_and_engagement_links_content

vanitabarrett · 2018-07-26T11:19:34Z

config/application.rb

-    config.autoload_paths += %W(#{config.root}/lib)
+    config.autoload_paths += %W(
+                                #{config.root}/lib
+                                #{config.root}/app/services/supergroups


This is great because it follows the pattern in Collections, but our previous work on Services and News (I think) puts everything in lib for now. It may make sense to follow that pattern for now and perhaps create a card to move everything into /services later.

vanitabarrett · 2018-07-26T11:20:20Z

app/views/content_items/_body_with_related_links.html.erb

+<% if @content_item.has_policy_and_engagement_links? %>
+  <%= render "govuk_publishing_components/components/highlight_boxes", {
+      items: @content_item.policy_and_engagement_links_content } %>
+<% end %>


Missing newline at end of file 🙂 You can probably configure your editor to do this automatically.

vanitabarrett · 2018-07-26T11:20:41Z

app/views/content_items/_body_with_related_links.html.erb

@@ -24,3 +24,8 @@

  <%= render 'shared/sidebar_navigation' %>
 </div>
+
+<% if @content_item.has_policy_and_engagement_links? %>


This logic looks good, but it needs to be added to shared/_taxonomy_navigation.html.erb

sihugh · 2018-07-27T12:13:18Z

@vanitabarrett I've addressed a few things and added tracking. Do you think you could re-review if you have some time please?

vanitabarrett · 2018-07-27T12:25:41Z

test/integration/answer_test.rb

@@ -1,6 +1,8 @@
 require 'test_helper'

 class AnswerTest < ActionDispatch::IntegrationTest
+  include RummagerHelpers


Is this needed here? Doesn't look like we're using it?

I'll check that, thanks

Removed, thanks

vanitabarrett · 2018-07-27T12:32:32Z

app/presenters/supergroups/supergroup.rb

+
+    def data_attributes(base_path, link_text, index)
+      {
+        track_category: data_module_label + "DocumentListClicked",


Looks like some of the tracking stuff won't work because the document list component doesn't have data-module="track-click", it requires you to wrap the document-list in an element with that attribute. Not sure how I didn't spot that with the services work, sorry! That'll need changing there too.

In the long term we probably just want to update the component to do this by default if someone passes tracking info, but it will require updating the other frontend apps.

I've wrapped the partial in the data-module now and it seems to work OK.

Adds guidance and regulation, and policy and engagement sections to the nav section at the footer of content pages. This is currently concealed from public view by an AB test. The navigation is visible if you're in the B sample of the ContentPagesNav test. The content page must itself be tagged to a live taxonomy, be rendered by this application and not be an HTML publication. Policy and engagement content is configured to get latest content. Guidance and regulation is retrieved by popularity (as determined by rummager). This PR is to get things generally close to the desired outcome and polish after a design review.

Wrapping the taxonomy block in a track-click data module activates link tracking. I've checked this in GA debug and it seems to do the trick. Also switching the guard clauses on each section from any? to present? as this checks whether hashes/arrays are nil or empty. (The services data can be nil)

benthorner temporarily deployed to government-frontend-pr-994 July 25, 2018 15:06 Inactive

oscarwyatt changed the title ~~Add most recent policy and engagement~~ [DO NOT MERGE] Add most recent policy and engagement Jul 25, 2018

vanitabarrett suggested changes Jul 26, 2018

View reviewed changes

oscarwyatt force-pushed the most_recent_policy_and_engagement branch from bf8c3aa to cae3074 Compare July 26, 2018 15:57

boffbowsh temporarily deployed to government-frontend-pr-994 July 26, 2018 15:57 Inactive

boffbowsh temporarily deployed to government-frontend-pr-994 July 26, 2018 16:04 Inactive

vanitabarrett mentioned this pull request Jul 26, 2018

Exclude current page from most popular searches #997

Merged

vanitabarrett force-pushed the most_recent_policy_and_engagement branch from 08f7761 to f817ab6 Compare July 26, 2018 16:26

boffbowsh deployed to government-frontend-pr-994 July 26, 2018 16:26 View deployment

sihugh force-pushed the most_recent_policy_and_engagement branch 4 times, most recently from 68062eb to de067d5 Compare July 27, 2018 09:34

sihugh changed the title ~~[DO NOT MERGE] Add most recent policy and engagement~~ [DO NOT MERGE] Add supergroup sections to taxonomy navigation Jul 27, 2018

sihugh force-pushed the most_recent_policy_and_engagement branch from de067d5 to b503d76 Compare July 27, 2018 10:44

sihugh changed the title ~~[DO NOT MERGE] Add supergroup sections to taxonomy navigation~~ Add supergroup sections to taxonomy navigation Jul 27, 2018

vanitabarrett suggested changes Jul 27, 2018

View reviewed changes

sihugh force-pushed the most_recent_policy_and_engagement branch from 68a0407 to 04ae708 Compare July 27, 2018 13:18

sihugh force-pushed the most_recent_policy_and_engagement branch from 04ae708 to ca92c35 Compare July 27, 2018 13:40

vanitabarrett approved these changes Jul 27, 2018

View reviewed changes

sihugh merged commit efac9eb into master Jul 27, 2018

sihugh deleted the most_recent_policy_and_engagement branch July 27, 2018 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add supergroup sections to taxonomy navigation #994

Add supergroup sections to taxonomy navigation #994

oscarwyatt commented Jul 25, 2018 •

edited by sihugh

Loading

vanitabarrett left a comment

vanitabarrett Jul 26, 2018

vanitabarrett Jul 26, 2018

vanitabarrett Jul 26, 2018

vanitabarrett Jul 26, 2018

vanitabarrett Jul 26, 2018

sihugh commented Jul 27, 2018

vanitabarrett Jul 27, 2018

sihugh Jul 27, 2018

sihugh Jul 27, 2018

vanitabarrett Jul 27, 2018

sihugh Jul 27, 2018

sihugh Jul 27, 2018

Add supergroup sections to taxonomy navigation #994

Add supergroup sections to taxonomy navigation #994

Conversation

oscarwyatt commented Jul 25, 2018 • edited by sihugh Loading

Examples:

vanitabarrett left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sihugh commented Jul 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oscarwyatt commented Jul 25, 2018 •

edited by sihugh

Loading