Add tests and tracking for guidance / policy sections

Wrapping the taxonomy block in a track-click data module activates link
tracking.  I've checked this in GA debug and it seems to do the trick.

Also switching the guard clauses on each section from any? to present? as this
checks whether hashes/arrays are nil or empty.  (The services data can be nil)

Author: sihugh

app/presenters/supergroups/supergroup.rb

@@ -2,12 +2,13 @@ module Supergroups
   class Supergroup
   private
 
-    def format_document_data(documents, include_timestamp: true)
-      documents&.map do |document|
+    def format_document_data(documents, data_category: nil, include_timestamp: true)
+      documents.each.with_index(1).map do |document, index|
         data = {
           link: {
             text: document["title"],
-            path: document["link"]
+            path: document["link"],
+            data_attributes: data_attributes(document["link"], document["title"], index)
           },
           metadata: {
             document_type: document["content_store_document_type"].humanize
@@ -18,8 +19,27 @@ def format_document_data(documents, include_timestamp: true)
           data[:metadata][:public_updated_at] = Date.parse(document["public_timestamp"])
         end
 
+        if data_category.present?
+          data[:link][:data_attributes][:track_category] = data_module_label + data_category
+        end
+
         data
       end
     end
+
+    def data_attributes(base_path, link_text, index)
+      {
+        track_category: data_module_label + "DocumentListClicked",
+        track_action: index,
+        track_label: base_path,
+        track_options: {
+          dimension29: link_text
+        }
+      }
+    end
+
+    def data_module_label
+      self.class.name.demodulize.camelize(:lower)
+    end
   end
 end

app/views/shared/_taxonomy_navigation.html.erb

@@ -1,12 +1,12 @@
 <% if taxonomy_navigation.values().flatten.any? %>
-  <div class="taxonomy-navigation">
+  <div class="taxonomy-navigation" data-module="track-click">
     <h2>More in
       <% tagged_taxons.each do |tagged_taxon| %>
         <a class="taxonomy-navigation__title-link" href="<%= tagged_taxon[:taxon_link] %>"><%= tagged_taxon[:taxon_name] %></a>
       <% end %>
     </h2>
 
-    <% if taxonomy_navigation[:services].any? %>
+    <% if taxonomy_navigation[:services].present? %>
       <div class="taxonomy-navigation__section">
         <%= render "govuk_publishing_components/components/heading", {
           text: t('supergroups.services'),
@@ -26,7 +26,7 @@
       </div>
     <% end %>
 
-    <% if taxonomy_navigation[:guidance_and_regulation].any? %>
+    <% if taxonomy_navigation[:guidance_and_regulation].present? %>
       <div class="taxonomy-navigation__section">
         <%= render "govuk_publishing_components/components/heading", {
             text: t('supergroups.guidance_and_regulation'),
@@ -41,7 +41,7 @@
       </div>
     <% end %>
 
-    <% if taxonomy_navigation[:policy_and_engagement].any? %>
+    <% if taxonomy_navigation[:policy_and_engagement].present? %>
       <div class="taxonomy-navigation__section">
         <%= render "govuk_publishing_components/components/heading", {
             text: t('supergroups.policy_and_engagement'),

test/integration/content_pages_navigation_test.rb

@@ -57,6 +57,8 @@ class ContentPagesNavigationTest < ActionDispatch::IntegrationTest
 
   test "shows the Services section title and documents with tracking" do
     stub_rummager
+    stub_empty_guidance
+    stub_empty_policies
     setup_variant_b
 
     taxons = SINGLE_TAXON
@@ -85,6 +87,74 @@ class ContentPagesNavigationTest < ActionDispatch::IntegrationTest
     refute page.has_css?('h3', text: "Services")
   end
 
+  test "shows the Policy section title and documents with tracking" do
+    stub_rummager
+    stub_empty_services
+    stub_empty_guidance
+    setup_variant_b
+
+    taxons = SINGLE_TAXON
+
+    setup_and_visit_content_item_with_taxons('guide', taxons)
+
+    assert page.has_css?('h3', text: "Policy and engagement")
+
+    assert page.has_css?('.gem-c-document-list__item a[data-track-category="policyAndEngagementDocumentListClicked"]', text: 'Free school meals form')
+    assert page.has_css?('.gem-c-document-list__item a[data-track-action="1"]', text: 'Free school meals form')
+    assert page.has_css?('.gem-c-document-list__item a[data-track-label="/government/publications/meals"]', text: 'Free school meals form')
+  end
+
+  test "does not show the Policy section if there is no tagged content" do
+    stub_empty_rummager
+    setup_variant_b
+
+    taxons = SINGLE_TAXON
+
+    setup_and_visit_content_item_with_taxons('guide', taxons)
+
+    refute page.has_css?('h3', text: "Policy and engagement")
+  end
+
+  test "shows the Guidance section title and documents with tracking" do
+    stub_rummager
+    stub_empty_services
+    stub_empty_policies
+    setup_variant_b
+
+    taxons = SINGLE_TAXON
+
+    setup_and_visit_content_item_with_taxons('guide', taxons)
+
+    assert page.has_css?('h3', text: "Guidance and regulation")
+
+    assert page.has_css?('.gem-c-document-list__item a[data-track-category="guidanceAndRegulationDocumentListClicked"]', text: 'Free school meals form')
+    assert page.has_css?('.gem-c-document-list__item a[data-track-action="1"]', text: 'Free school meals form')
+    assert page.has_css?('.gem-c-document-list__item a[data-track-label="/government/publications/meals"]', text: 'Free school meals form')
+  end
+
+  test "does not show the Guidance section if there is no tagged content" do
+    stub_empty_rummager
+    setup_variant_b
+
+    taxons = SINGLE_TAXON
+
+    setup_and_visit_content_item_with_taxons('guide', taxons)
+
+    refute page.has_css?('h3', text: "Guidance and regulation")
+  end
+
+  def stub_empty_services
+    Supergroups::Services.any_instance.stubs(:all_services).returns({})
+  end
+
+  def stub_empty_guidance
+    Supergroups::GuidanceAndRegulation.any_instance.stubs(:tagged_content).returns([])
+  end
+
+  def stub_empty_policies
+    Supergroups::PolicyAndEngagement.any_instance.stubs(:tagged_content).returns([])
+  end
+
   def setup_variant_a
     ContentItemsController.any_instance.stubs(:show_new_navigation?).returns(false)
   end