Remove integration test for the UR banner #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test will fail once we pass the expiration date of the banner in the gem. We could add a setup and tear down to set the time to be within the banner start and end date, but this will only result in apassing test whilst the config remains in the gem. If someone removes the config from the gem (clearing up after the banner has expired) and forgets to remove this test, then deploys of this application would be blocked. This seems bad, and somewhat defeats the purpose of having the code in a gem.
hannako
force-pushed
the
remove_integration_tests
branch
from
a90c9ce to
ab8a1f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test will fail once we pass the expiration date of the banner in the gem.
We could add a setup and tear down to set the time to be within the banner
start and end date, but this will only result in a passing test whilst the config remains
in the gem. If someone removes the config from the gem (clearing up after the banner has expired)
and forgets to remove this test, then deploys of this application would be blocked.
This seems bad, and somewhat defeats the purpose of having the code in a gem.