Skip to content

Commit

Permalink
Remove intergration test for the UR banner
Browse files Browse the repository at this point in the history
This test will fail once we pass the expiration date of the banner in the gem.
We could add a setup and tear down to set the time to be within the banner
start and end date, but this will only result in apassing test whilst the config remains
in the gem.  If someone removes the config from the gem (clearing up after the banner has expired)
and forgets to remove this test, then deploys of this application would be blocked.
This seems bad, and somewhat defeats the purpose of having the code in a gem.
  • Loading branch information
hannako committed Dec 11, 2024
1 parent 139c4a2 commit ab8a1f6
Showing 1 changed file with 0 additions and 63 deletions.
63 changes: 0 additions & 63 deletions test/integration/recruitment_banner_test.rb

This file was deleted.

0 comments on commit ab8a1f6

Please sign in to comment.