-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Dart Sass from LibSass #3034
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
force-pushed
the
migrate-to-dart-sass
branch
from
January 5, 2024 09:49
33d8e7b
to
68305bf
Compare
jon-kirwan
force-pushed
the
migrate-to-dart-sass
branch
from
January 12, 2024 10:23
68305bf
to
a2a55c9
Compare
jon-kirwan
force-pushed
the
migrate-to-dart-sass
branch
from
January 12, 2024 10:30
a2a55c9
to
eaabcf5
Compare
jon-kirwan
force-pushed
the
migrate-to-dart-sass
branch
from
January 12, 2024 15:43
eaabcf5
to
c91f4c3
Compare
jon-kirwan
force-pushed
the
migrate-to-dart-sass
branch
from
January 17, 2024 14:18
c91f4c3
to
3c2a90d
Compare
jon-kirwan
force-pushed
the
migrate-to-dart-sass
branch
from
January 17, 2024 14:57
3c2a90d
to
d45241a
Compare
matthillco
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and on integration. Looks good, no errors or warnings. Nice job.
- Create `dartsass.builds` initializer and add all Sass files to be compiled. See https://github.com/rails/dartsass-rails#configuring-builds - Create .keep - Update manifest file to use /builds directory - Ignore /builds
Also, turn digests off in development
jon-kirwan
force-pushed
the
migrate-to-dart-sass
branch
from
January 22, 2024 10:31
d45241a
to
d738a71
Compare
jon-kirwan
changed the title
Migrate to Dart Sass from LibSass
Migrate to Dart Sass from LibSass
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Migrate to Dart Sass from LibSass.
Why
Visual Changes
None.
How can I test these changes?
yarn jasmine:prepare
(or runbundle exec rake app:assets:clobber app:assets:precompile
)/builds
folder:app/assets/builds
should now be populated with CSS files. Note, the/public
directorydartsass-rails
is bundled and any Dart Sass warnings encountered during the compilation process are reported)guide, detailed guide, HTML publication, news article, specialist document, statistical dataset, foreign travel advice, worldwide organisation to ensure the absence of errors.
Anything else
Once the PR gets the green light, any temporary commits and references to local gems e.g.
gem "govuk_publishing_components", path: "../govuk_publishing_components"
will be removed.See: