Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump govuk_publishing_components from 36.0.2 to 37.1.1 #3020

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 19, 2023

Bumps govuk_publishing_components from 36.0.2 to 37.1.1.

Changelog

Sourced from govuk_publishing_components's changelog.

37.1.1

37.1.0

37.0.0

36.1.0

36.0.3

Commits
  • 4662a7f Merge pull request #3785 from alphagov/version-37.1.1
  • 13703a3 Version 37.1.1
  • 59f7401 Merge pull request #3779 from alphagov/dependabot/npm_and_yarn/stylelint-conf...
  • 2b7d4fa Bump stylelint-config-gds from 1.1.0 to 1.1.1
  • 8348382 Merge pull request #3783 from alphagov/dependabot/npm_and_yarn/stylelint-styl...
  • dde744f Merge pull request #3784 from alphagov/dependabot/github_actions/actions/setu...
  • 20f75aa Merge pull request #3699 from alphagov/fix-assets-header-footer-links
  • 1cdd65f Make global relative links absolute
  • 6a0615a Merge pull request #3782 from alphagov/dependabot/bundler/govuk_test-4.0.2
  • 6f5dbb8 Revert "Filter out failing test"
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Dec 19, 2023
Copy link

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3020 December 19, 2023 11:33 Inactive
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 36.0.2 to 37.1.1.
- [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_publishing_components@v36.0.2...v37.1.1)

---
updated-dependencies:
- dependency-name: govuk_publishing_components
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/govuk_publishing_components-37.1.1 branch from 360fef8 to 08c4734 Compare January 4, 2024 11:51
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3020 January 4, 2024 11:51 Inactive
Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked through a bunch of pages locally and not seeing any issues.

I've also gone through the Changelog to double check for any issues, below are my notes for the record:

36.0.3

Standardise search term formatting across GA4 trackers (PR #3746)

Clean up, not a breaking change

Add ZIP file support to attachment component (PR #3751)

This adds a new feature

36.1.0

Add heading option to file input component (PR #3755)

This adds a new feature

37.0.0

[BREAKING] Data attributes for option select button (PR #3750)

Component not used by this repo

Remove doNotTrack from GTM component (PR #3760)

Removes a deprecated GTM feature, no perceivable impact

Fix rendering of the image card YouTube variation #3757 (PR #3757)

Component not used by this repo

Move image-card overrides from frontend app (PR #3752)

This is specically about the two thirds variant of the image card component which is not used by this repo.

Migrate to Dart Sass from LibSass (PR #3604)

I've run npm run lint:scss and not seeing any issues. This repo is currently being moved over to Dart SASS too.

37.1.0

Remove hardcoded text from GA4 'Feedback component' tracking, and add disable_ga4 option (PR #3769)

Component not used by this repo

Add GA4 copy event tracker (PR #3761)

This adds a new feature

Silence Sass deprecation warnings for dependencies (PR #3771)

Internal change to the gem

Fix duplicate font download issue (PR #3772)

Removes some duplicated code, no perceivable impact

37.1.1

Make global relative links absolute (PR #3699)

This impacts the header and the footer which aren't handled by this repo and it's also not marked as a breaking change. I've checked the header and footer links on the repo preview anyway and the links are correct

Remove duplicate GA4 tracking (PR #3781)

This has been investigated by Ash and reviewed by Andy specifically in this repo. It's a minor change anyway and not a breaking one.

Delete unused builds folder (PR #3778)

Internal change to the gem

Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hannalaakso , yes this shouldn't cause any problems despite the large amount of changelog entries 👍

@AshGDS AshGDS merged commit 1410637 into main Jan 9, 2024
12 checks passed
@AshGDS AshGDS deleted the dependabot/bundler/govuk_publishing_components-37.1.1 branch January 9, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants