Serve basic pages from content-store #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroseman
force-pushed
the
content-store
branch
from
a018e9e to
4180fac
Compare
| @@ -1,5 +1,23 @@ | |||
| class ApplicationController < ActionController::Base | |||
| # Prevent CSRF attacks by raising an exception. | |||
| # For APIs, you may want to use :null_session instead. | |||
| include Slimmer::Headers | |||
There was a problem hiding this comment.
Probably best not to include any of the slimmer bits to avoid conflicts as @edds is adding them separately in the work he's doing.
added 2 commits
November 18, 2014 10:23
Basic functionality to get an item to the content store and display it on a page. Views are very basic at this point, and controller just passes the content hash directly to the page.
danielroseman
force-pushed
the
content-store
branch
from
4180fac to
1416d6f
Compare
| "public_updated_at": "2012-12-17T15:45:44.000+00:00", | ||
| "publishing_app": "whitehall", | ||
| "redirects": [], | ||
| "rendering_app": "whitehall-frontend", |
There was a problem hiding this comment.
I was expecting this to be government-frontend?
There was a problem hiding this comment.
@dsingleton Good catch, updated.
There was a problem hiding this comment.
It should only be government-frontend when the new app is actually rendering the content on GOV.UK. For now, we're pushing case studies into content store with the existing whitehall frontend app as the rendering app. Once we are happy that the frontend app is fully rendering the content, we will switch the rendering app to government-frontend.
danielroseman
force-pushed
the
content-store
branch
from
67e88a3 to
92ce3c2
Compare
danielroseman
force-pushed
the
content-store
branch
from
92ce3c2 to
3461b95
Compare
tekin
added a commit
that referenced
this pull request
Nov 18, 2014
Serve basic pages from content-store
|
👍 👍 |
karlbaker02
pushed a commit
that referenced
this pull request
Mar 6, 2019
This commit updates the A/B test variant for related links from RelatedLinksABTest2 to RelatedLinksABTest3. This is to support the third iteration of the A/B test which is using a new set of related link data.
karlbaker02
pushed a commit
that referenced
this pull request
Mar 7, 2019
Update related links A/B test variant for test #3
karlbaker02
pushed a commit
that referenced
this pull request
Mar 12, 2019
This commit adds an additional `C` variant for the upcoming related links A/B test iteration #3. In the previous test we saw some users who had the control variant cookie, yet navigated via the related links which are only shown on the `B` variant. In order to check if there are any problems with our A/B testing framework, in addition to making the data collection easier for later analysis, we are introducing the new `C` variant which will become our test variant. How the variants now work are as follows: - `A` variant: No users should ever end up in this variant, as our CDN will be configured it to assign 0% of users. If users do end up in this variant, we may have issues with our A/B testing framework which will require further investigation. - `B` variant: Our control variant, where related links will not be changed in any way. - `C` variant: Our test variant, where related links will be changed to use our generated links for the sample involved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get an item from the content store and display it on a page. Views are very basic at this point, and controller just passes the content hash directly to the page.