Merge pull request #1269 from alphagov/add-related-links-ab3-test

Update related links A/B test variant for test #3
alphagov · Mar 7, 2019 · 61c9e0b · 61c9e0b
2 parents 7d5ccd2 + cafca8c
commit 61c9e0b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/app/controllers/concerns/ab_testable.rb b/app/controllers/concerns/ab_testable.rb
@@ -16,7 +16,7 @@ def related_links_variant
 
   def related_links_test
     @related_links_test ||= GovukAbTesting::AbTest.new(
-      "RelatedLinksABTest2",
+      "RelatedLinksABTest3",
       dimension: RELATED_LINKS_DIMENSION,
       allowed_variants: %w(A B),
       control_variant: "A"

diff --git a/test/controllers/content_items_controller_test.rb b/test/controllers/content_items_controller_test.rb
@@ -130,8 +130,8 @@ class ContentItemsControllerTest < ActionController::TestCase
     assert_equal content_item['title'], assigns[:content_item].title
   end
 
-  test "gets item from the content store and keeps ordered_related_items when running RelatedLinksABTest2 control variant" do
-    with_variant RelatedLinksABTest2: 'A' do
+  test "gets item from the content store and keeps ordered_related_items when running RelatedLinksABTest3 control variant" do
+    with_variant RelatedLinksABTest3: 'A' do
       content_item = content_store_has_schema_example('case_study', 'case_study')
 
       get :show, params: { path: path_for(content_item) }
@@ -140,8 +140,8 @@ class ContentItemsControllerTest < ActionController::TestCase
     end
   end
 
-  test "gets item from the content store and replaces ordered_related_items when running RelatedLinksABTest2 test variant" do
-    with_variant RelatedLinksABTest2: 'B' do
+  test "gets item from the content store and replaces ordered_related_items when running RelatedLinksABTest3 test variant" do
+    with_variant RelatedLinksABTest3: 'B' do
       content_item = content_store_has_schema_example('case_study', 'case_study')
 
       get :show, params: { path: path_for(content_item) }
@@ -150,8 +150,8 @@ class ContentItemsControllerTest < ActionController::TestCase
     end
   end
 
-  test "gets item from the content store and replaces ordered_related_items when empty array when RelatedLinksABTest2 test variant has no suggestions" do
-    with_variant RelatedLinksABTest2: 'B' do
+  test "gets item from the content store and replaces ordered_related_items when empty array when RelatedLinksABTest3 test variant has no suggestions" do
+    with_variant RelatedLinksABTest3: 'B' do
       content_item = content_store_has_schema_example('guide', 'guide')
 
       get :show, params: { path: path_for(content_item) }

diff --git a/test/controllers/development_controller_test.rb b/test/controllers/development_controller_test.rb
@@ -4,8 +4,8 @@ class DevelopmentControllerTest < ActionController::TestCase
   include GovukAbTesting::MinitestHelpers
 
   %w(A B).each do |test_variant|
-    test "RelatedLinksABTest2 works correctly for each variant (variant: #{test_variant})" do
-      with_variant RelatedLinksABTest2: test_variant do
+    test "RelatedLinksABTest3 works correctly for each variant (variant: #{test_variant})" do
+      with_variant RelatedLinksABTest3: test_variant do
         get :index
 
         ab_test = @controller.send(:related_links_test)