Auditing fixes #2975
Merged
Auditing fixes #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- scripts were not being included for these components even though they are in use in this application
- style added 20px margin top to the intervention component - component is already wrapped in an element that has 20px margin top, so this rule did nothing - applications shouldn't style components, changes should be made directly to components or component options
- and replace with new option from the component - inverse option for metadata automatically had extra spacing around it, this was being removed by this style override - can be seen on pages such as https://www.gov.uk/guidance/the-highway-code
andysellick
force-pushed
the
auditing-fixes
branch
from
369edda to
a846908
Compare
MartinJJones
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Addresses some issues to do with component use and practices in this application. See individual commits for details.
Why
Issues raised by our component auditing tools.
Visual changes
None.