Skip to content

Commit

Permalink
Remove metadata component style override
Browse files Browse the repository at this point in the history
- and replace with new option from the component
- inverse option for metadata automatically had extra spacing around it, this was being removed by this style override
- can be seen on pages such as https://www.gov.uk/guidance/the-highway-code
  • Loading branch information
andysellick committed Oct 30, 2023
1 parent 4511b94 commit a846908
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
9 changes: 0 additions & 9 deletions app/assets/stylesheets/views/_manual.scss
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,6 @@
&.hmrc {
background: govuk-organisation-colour("hm-revenue-customs");
}

.gem-c-metadata--inverse {
background: none;
padding: 0;

.gem-c-metadata__list {
margin: 0;
}
}
}

.section-list {
Expand Down
1 change: 1 addition & 0 deletions app/presenters/content_item/manual.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ def manual_metadata
first_published: published,
other: other_metadata,
inverse: true,
inverse_compress: true,
}
end

Expand Down
3 changes: 2 additions & 1 deletion test/presenters/content_item/manual_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,11 @@ def initialize(schema_name = "manual")
expected_metadata = {
from: ["<a class=\"govuk-link\" href=\"/blah\">blah</a>"],
first_published: "23 March 2022",
inverse: true,
other: {
I18n.t("manuals.updated") => "23 March 2022, <a href=\"/a/base/path/updates\">#{I18n.t('manuals.see_all_updates')}</a>",
},
inverse: true,
inverse_compress: true,
}
assert_equal expected_metadata, item.manual_metadata
end
Expand Down

0 comments on commit a846908

Please sign in to comment.