Bump stylelint-config-gds from 0.3.0 to 1.0.0 #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
javascript
|
Follow these steps if you are doing a Rails upgrade. |
|
We cannot fix the Stylint error by using the new CSS media query range syntax, as we will get a new error when trying to compile the CSS. The reason for this is that we use the sassc-rails gem to compile our CSS, this includes the deprecated LibSass library which does not understand the new CSS media query range syntax. This can be fixed either by:
|
Bumps [stylelint-config-gds](https://github.com/alphagov/stylelint-config-gds) from 0.3.0 to 1.0.0. - [Changelog](https://github.com/alphagov/stylelint-config-gds/blob/main/CHANGELOG.md) - [Commits](alphagov/stylelint-config-gds@0.3.0...1.0.0) --- updated-dependencies: - dependency-name: stylelint-config-gds dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/stylelint-config-gds-1.0.0
branch
from
9189c8d to
fd4bc10
Compare
hannako
force-pushed
the
dependabot/npm_and_yarn/stylelint-config-gds-1.0.0
branch
from
f9b61dd to
017b875
Compare
catalinailie
approved these changes
Aug 24, 2023
hannako
force-pushed
the
dependabot/npm_and_yarn/stylelint-config-gds-1.0.0
branch
from
017b875 to
d60c5cb
Compare
We cannot fix the Stylint error by using the new CSS media query range syntax, as we will get a new error when trying to compile the CSS. The reason for this is that we use the sassc-rails gem to compile our CSS, this includes the deprecated LibSass library which does not understand the new CSS media query range syntax. This can be fixed either by: - Disabling the failing stylelint rules // stylelint-disable-line foo - Moving to DartSass (Not immediate) Trello card - https://trello.com/c/4OgdZ7Yi/2145-spike-into-upgrading-to-dart-sass
hannako
force-pushed
the
dependabot/npm_and_yarn/stylelint-config-gds-1.0.0
branch
from
d60c5cb to
01a043e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps stylelint-config-gds from 0.3.0 to 1.0.0.
Changelog
Sourced from stylelint-config-gds's changelog.
Commits
5cdee07Merge pull request #32 from alphagov/stylelint-1502e3c62Merge pull request #44 from alphagov/remove-deprecated-stylistic-rulesa11aff1Bump version to 1.0.0bebac04Add CHANGELOG entry for Stylelint 15b8c402eUpdate stylelint dependencies for stylelint 15.xff52d25Fix moved Stylelint rule documentation URLsb6f49d0Add CHANGELOG entry for deprecated stylistic rules removald988cb8Remove deprecated stylistic rulesc5d793eAdd CHANGELOG entry forselector-pseudo-element-colon-notationremoval6c17ceaMerge pull request #43 from alphagov/dependabot/npm_and_yarn/word-wrap-1.2.4Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)