Skip to content

Commit

Permalink
Disable failing stylelint rules
Browse files Browse the repository at this point in the history
We cannot fix the Stylint error by using the new CSS media query
range syntax, as we will get a new error when trying to compile the CSS.
The reason for this is that we use the sassc-rails gem to compile our CSS,
this includes the deprecated LibSass library which does not understand the
new CSS media query range syntax.

This can be fixed either by:

- Disabling the failing stylelint rules
// stylelint-disable-line foo

- Moving to DartSass (Not immediate)
Trello card - https://trello.com/c/4OgdZ7Yi/2145-spike-into-upgrading-to-dart-sass
  • Loading branch information
hannako committed Aug 24, 2023
1 parent fd4bc10 commit 01a043e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/assets/stylesheets/modules/_page-contents.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
margin-left: govuk-spacing(0);
padding-right: govuk-spacing(3);

&:before {
&::before {
content: "";
display: inline-block;
padding-right: govuk-spacing(1);
Expand Down
4 changes: 2 additions & 2 deletions app/assets/stylesheets/views/_worldwide-organisation.scss
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@
}

li {
@media (min-width: 1px) { // target modern browsers
@media (min-width: 1px) { // stylelint-disable-line media-feature-range-notation
list-style: none;
padding-left: $govuk-gutter-half;
@include govuk-responsive-padding(1, "top");

&:before {
&:before { // stylelint-disable-line selector-pseudo-element-colon-notation
content: "-";
position: relative;
float: left;
Expand Down

0 comments on commit 01a043e

Please sign in to comment.