Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment variable name to make search work for review apps #2715

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

hannako
Copy link
Contributor

@hannako hannako commented Mar 14, 2023

app.json is used to configure the env vars for Heroku.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2715 March 14, 2023 13:15 Inactive
@hannako hannako force-pushed the update_search_vars branch from 593afe2 to d514b8f Compare March 14, 2023 13:21
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2715 March 14, 2023 13:22 Inactive
@hannako hannako changed the title Update env var name Update environment variable name to make search work for review apps Mar 14, 2023
@hannako hannako marked this pull request as ready for review March 14, 2023 13:26
@hannako hannako mentioned this pull request Mar 14, 2023
@hannako hannako requested review from brucebolt and AgaDufrat March 14, 2023 13:27
Copy link
Contributor

@AgaDufrat AgaDufrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One day we will remove all references to rummager 😂

@hannako hannako merged commit 63cad1e into main Mar 14, 2023
@hannako hannako deleted the update_search_vars branch March 14, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants