Refactor Get Involved #2712
Refactor Get Involved #2712
Conversation
brucebolt
force-pushed
the
refactor-get-involved
branch
from
bc29e8a to
1bf6d03
Compare
This page was created differently to all the other content types. Refactoring so it is the same as everything else. Co-authored-by: Jon Hallam <[email protected]>
brucebolt
force-pushed
the
refactor-get-involved
branch
from
1bf6d03 to
f21a0ba
Compare
Yes, I think it's because this app's Heroku setup doesn't include the env var to provide the URL for live search. This is the only document type in Government Frontend that uses search, so maybe it's not the right app for the document to be rendered by 🤔. |
| link: { | ||
| text: item["title"], | ||
| path: item["link"], | ||
| description: "#{close_status} #{item['end_date'].to_date.strftime('%d %B %z')}", |
There was a problem hiding this comment.
I think we may need to change the date formatting here
| description: "#{close_status} #{item['end_date'].to_date.strftime('%d %B %z')}", | |
| description: "#{close_status} #{item['end_date'].to_date.strftime('%d %B %Y')}", |
so the year is displayed instead of the timezone.
There was a problem hiding this comment.
Good spot! I don't know how that changed, since I just copy and pasted the stuff over 🤷♂️.
There was a problem hiding this comment.
I'll raise a PR to fix this.
This was incorrectly added in #2712, so fixing to display the year instead of the timezone.
This fixes the review apps #2715 |
This page was created differently to all the other content types.
Refactoring so it is the same as everything else.
The test coverage isn't as good as it should be, but retains the same level of testing as before the refactor.
Tests depend on alphagov/publishing-api#2312.
Follow these steps if you are doing a Rails upgrade.