Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary mkdir /app from Dockerfile. #2563

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Remove unnecessary mkdir /app from Dockerfile. #2563

merged 1 commit into from
Oct 3, 2022

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Oct 3, 2022 •
edited
Loading

WORKDIR creates its directory anyway, and the mkdir fails now that we're creating /app in govuk-ruby-base. Thought I'd fixed all these before merging the change to govuk-ruby-base, but turns out I forgot to actually raise a bunch of the PRs that I'd prepared.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2563 October 3, 2022 15:45 Inactive
@sengi sengi requested a review from nsabri1 October 3, 2022 15:55
nsabri1
nsabri1 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@nsabri1 nsabri1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sengi sengi merged commit 20b5401 into main Oct 3, 2022
@sengi sengi deleted the sengi/dockerfile branch October 3, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsabri1 nsabri1 nsabri1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sengi @nsabri1 @govuk-ci