Skip to content

Commit

Permalink
Merge pull request #2563 from alphagov/sengi/dockerfile
Browse files Browse the repository at this point in the history
Remove unnecessary `mkdir /app` from Dockerfile.
  • Loading branch information
sengi authored Oct 3, 2022
2 parents 3cf03bb + 2e33d84 commit 20b5401
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,23 +1,20 @@
ARG base_image=ghcr.io/alphagov/govuk-ruby-base:2.7.6
ARG builder_image=ghcr.io/alphagov/govuk-ruby-builder:2.7.6

FROM $builder_image AS builder

RUN mkdir /app
FROM $builder_image AS builder

WORKDIR /app

COPY Gemfile* .ruby-version /app/

COPY Gemfile* .ruby-version ./
RUN bundle install

COPY . /app
# TODO: We probably don't want assets in the image; remove this once we have a proper deployment process which uploads to (e.g.) S3.
RUN bundle exec rails assets:precompile && rm -rf /app/log


FROM $base_image

# TODO: remove PORT and set it in publishing-e2e-tests instead.
ENV GOVUK_APP_NAME=government-frontend PORT=3090

COPY --from=builder /usr/local/bundle/ /usr/local/bundle/
Expand Down

0 comments on commit 20b5401

Please sign in to comment.