Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch title from manuals content item #2496

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Fetch title from manuals content item #2496

merged 3 commits into from
Jul 21, 2022

Conversation

1pretz1
Copy link
Contributor

@1pretz1 1pretz1 commented Jul 21, 2022 •
edited
Loading

This PR does the following:

  • Fetch title from manuals content item for a HMRC section, rather than pulling it from it's own content item, as this functionality is going to be removed soon
  • Removes TODOs that no longer apply
  • Improves how we fetch the manual content item for breadcrumbs by reducing coupling

Trello:
https://trello.com/c/ItYKGMqF/1464-revert-add-parent-manuals-title-to-the-hmrc-section-content-item

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@1pretz1 1pretz1 force-pushed the remove-todo-comments branch from 0a0da87 to d8263dd Compare July 21, 2022 14:50
@1pretz1 1pretz1 force-pushed the remove-todo-comments branch from d8263dd to f485c27 Compare July 21, 2022 14:59
KludgeKML
KludgeKML approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1pretz1 1pretz1 merged commit b1b8476 into main Jul 21, 2022
@1pretz1 1pretz1 deleted the remove-todo-comments branch July 21, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KludgeKML KludgeKML KludgeKML approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1pretz1 @KludgeKML