Add parsed_content_item method to clean up code

alphagov · Jul 21, 2022 · f485c27 · f485c27
1 parent 0666708
commit f485c27
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/app/presenters/content_item/manual_section.rb b/app/presenters/content_item/manual_section.rb
@@ -23,6 +23,10 @@ def manual_content_item
       @manual_content_item ||= Services.content_store.content_item(base_path)
     end
 
+    def parsed_content_item
+      manual_content_item.parsed_content
+    end
+
     def published
       display_date(manual_content_item["first_published_at"])
     end

diff --git a/app/presenters/content_item_presenter.rb b/app/presenters/content_item_presenter.rb
@@ -36,6 +36,10 @@ def initialize(content_item, requested_path, view_context)
     @part_slug = requesting_a_part? ? requested_path.split("/").last : nil
   end
 
+  def parsed_content_item
+    content_item.parsed_content
+  end
+
   def requesting_a_part?
     false
   end

diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
@@ -42,8 +42,7 @@
         <%= render 'govuk_publishing_components/components/breadcrumbs',
                    breadcrumbs: [ { url: "/", title: "Home" } , { url: "/brexit", title: "Brexit" } ] %>
       <% else %>
-        <%= render 'govuk_publishing_components/components/contextual_breadcrumbs',
-                   content_item: @content_item.try(:manual_content_item) || @content_item.content_item.parsed_content %>
+        <%= render 'govuk_publishing_components/components/contextual_breadcrumbs', content_item: @content_item.parsed_content_item %>
       <% end %>
     <% end %>