Convert set ga code to our module format #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses our standard module pattern for this code - means we can remove the manual initialisation in application.js - and add the module name to the form where the code is used
kevindew
reviewed
Nov 10, 2021
- no need for linting rule anymore - class for initialisation isn't used anymore either
andysellick
force-pushed
the
convert-set-ga-js-to-module
branch
from
31a6102 to
e028b8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Converts the set ga id on form code to use our standard JS modules format. This is used on https://www.gov.uk/check-income-tax-current-year/sign-in/prove-identity
Why
We're trying to standardise our approach to JS and having it in our modules format means we also don't need to manually initialise this code in
application.jsanymore.Visual changes
None.
Trello card: https://trello.com/c/bqdisKbm/277-from-jquery-from-government-frontend-set-ga-client-id-on-formjs-and-applicationjs-moderate-js-knowledge-required