Update tests and last tweaks

- no need for linting rule anymore
- class for initialisation isn't used anymore either

app/views/content_items/service_sign_in/_choose_sign_in.html.erb

@@ -21,8 +21,7 @@
 %>
 <%= form_tag({controller: 'content_items', action: 'service_sign_in_options'},
              method: "post",
-             data: data_attrs,
-             class: 'js-service-sign-in-form') do %>
+             data: data_attrs) do %>
   <% legend_text = render 'govuk_publishing_components/components/title', title: @content_item.title %>
   <%= render "govuk_publishing_components/components/fieldset", legend_text: legend_text do %>
     <div class="govuk-grid-row">

spec/javascripts/set-ga-client-id-on-form.spec.js

@@ -8,10 +8,8 @@ describe('SetGaClientIdOnForm', function () {
   var form
 
   beforeEach(function () {
-    form = $(
-      '<form class="js-service-sign-in-form" action="/endpoint"></form>'
-    )
-    var setId = new GOVUK.Modules.SetGaClientIdOnForm(form[0]) // eslint-disable-line no-new
+    form = $('<form action="/endpoint"></form>')
+    var setId = new GOVUK.Modules.SetGaClientIdOnForm(form[0])
     setId.init()
   })
 

test/integration/service_sign_in/choose_sign_in_test.rb

@@ -20,7 +20,7 @@ class ChooseSignInTest < ActionDispatch::IntegrationTest
       assert_not page.has_css?("#proposition-menu")
 
       assert page.has_css?('.gem-c-back-link[href="/log-in-file-self-assessment-tax-return"]', text: "Back")
-      assert page.has_css?('form[data-module="track-radio-group"]')
+      assert page.has_css?('form[data-module="track-radio-group set-ga-client-id-on-form"]')
       assert page.has_css?("form[data-tracking-code='UA-xxxxxx']")
       assert page.has_css?("form[data-tracking-domain='tax.service.gov.uk']")
       assert page.has_css?("form[data-tracking-name='somethingClicky']")