Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some analytics to the brexit child taxon pages #2123

Merged
merged 5 commits into from
Jun 10, 2021
Merged

Add some analytics to the brexit child taxon pages #2123

merged 5 commits into from
Jun 10, 2021

Conversation

hannako
Copy link
Contributor

@hannako hannako commented May 28, 2021 •
edited
Loading

What

We need to add some tracking to the links on the new brexit child taxon pages. Because the content of detailed guides is sent to government-frontend as a string of html in the details hash of the content item, we need to parse it before we can add the data attributes. See commit message for more information.

To test this works:

But if that is a bit of a faff here are some screen shots:

Screenshot 2021-05-28 at 23 22 41

Screenshot 2021-05-28 at 23 22 57

trello https://trello.com/c/RqR5gkX2/1541-add-tracking-to-brexit-child-taxon-pages

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@hannako hannako requested review from sihugh and alex-ju May 28, 2021 22:25
@bevanloon bevanloon temporarily deployed to government-f-brexit-hub-ro4rz2 May 28, 2021 22:25 Inactive
@bevanloon bevanloon temporarily deployed to government-f-brexit-hub-ro4rz2 June 1, 2021 09:44 Inactive
@sihugh sihugh force-pushed the brexit_hub_analytics branch from 708205d to 9d890da Compare June 3, 2021 08:59
@bevanloon bevanloon temporarily deployed to government-f-brexit-hub-ro4rz2 June 3, 2021 08:59 Inactive
@alex-ju alex-ju force-pushed the brexit_hub_analytics branch from 9d890da to 472001a Compare June 7, 2021 08:41
@bevanloon bevanloon temporarily deployed to government-f-brexit-hub-ro4rz2 June 7, 2021 08:41 Inactive
@hannako hannako force-pushed the brexit_hub_analytics branch from 472001a to 80143ef Compare June 9, 2021 13:59
@bevanloon bevanloon temporarily deployed to government-f-brexit-hub-ro4rz2 June 9, 2021 14:00 Inactive
@hannako hannako force-pushed the brexit_hub_analytics branch from 80143ef to 4b4c4b1 Compare June 9, 2021 14:24
@bevanloon bevanloon temporarily deployed to government-f-brexit-hub-ro4rz2 June 9, 2021 14:25 Inactive
@hannako hannako force-pushed the brexit_hub_analytics branch from 4b4c4b1 to 7ba9578 Compare June 9, 2021 15:11
@bevanloon bevanloon temporarily deployed to government-f-brexit-hub-ro4rz2 June 9, 2021 15:11 Inactive
alex-ju
alex-ju approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@alex-ju alex-ju left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend and tracking look great! Not confident to assess the Nokogiri-based parser though – you might want to wait for Simon for that

@hannako hannako force-pushed the brexit_hub_analytics branch from 7ba9578 to 15b2ffe Compare June 9, 2021 15:25
@bevanloon bevanloon temporarily deployed to government-f-brexit-hub-ro4rz2 June 9, 2021 15:25 Inactive
@hannako hannako force-pushed the brexit_hub_analytics branch from 15b2ffe to cac3123 Compare June 9, 2021 15:45
@bevanloon bevanloon temporarily deployed to government-f-brexit-hub-ro4rz2 June 9, 2021 15:45 Inactive
hannako added 5 commits June 9, 2021 16:47
@hannako
Create parser to process html body content
092b64e 
- Whitehall sends the body content of detailed_guides as a string of html
in the details attribute of the content item. The brexit child taxon
pages are detailed_guides but we need to add some tracking
to the links contained in this blob. So we need to parse it first.
@hannako
Small refactor of detailed_guide view
a12c5b0
@hannako
Create a partial to display the parsed body content
1a1c8e9
@hannako
Add tracking to the bulleted list of links
76228b3
@hannako
Add some tracking to the description link
a6e81c7
@hannako hannako force-pushed the brexit_hub_analytics branch from cac3123 to a6e81c7 Compare June 9, 2021 15:48
@bevanloon bevanloon temporarily deployed to government-f-brexit-hub-ro4rz2 June 9, 2021 15:49 Inactive
sihugh
sihugh approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@sihugh sihugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ Obvs we should get Ash to kick the tyres, but merge away

@hannako hannako merged commit e9c40f6 into main Jun 10, 2021
@hannako hannako deleted the brexit_hub_analytics branch June 10, 2021 10:18
hannako added a commit that referenced this pull request Oct 25, 2022
@hannako
Remove body parser code
38678d7 
This was added [here](#2123)
and is no longer being used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-ju alex-ju alex-ju approved these changes

@sihugh sihugh sihugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hannako @sihugh @alex-ju @bevanloon