Customise detailed guide pages for Brexit hubs #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further modifications
- Hide publisher metadata and print link
- Render description field as a link
- Hide print link at bottom of page
- Hide the context field ("Guidance") from above the title
- Replace the superbreadcrumb with a standard breadcrumb.
- Reduce description size and hide published date
hannako
commented
May 27, 2021
| @@ -42,6 +42,8 @@ | |||
| <% unless @do_not_show_breadcrumbs %> | |||
| <% if @content_item.try(:back_link) %> | |||
| <%= render 'govuk_publishing_components/components/back_link', href: @content_item.back_link %> | |||
| <% elsif @content_item.brexit_hub_page? %> | |||
| <%= render 'govuk_publishing_components/components/breadcrumbs', breadcrumbs: [ { url: "/", title: "Home" } , { url: "/transition", title: "Brexit" } ] %> | |||
There was a problem hiding this comment.
Once we have updated the contextual nav in publishing components this hardcoding can be removed.
hannako
changed the title
hannako
changed the title
sihugh
reviewed
May 28, 2021
alex-ju
reviewed
May 28, 2021
- english only at this point - simplify brexit_hub_page presenter
hannako
changed the title
sihugh
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We are using the detailed guide doc type to publish the brexit child taxon pages, but we need to customise a few things.
See commit message for more details.
The review apps for this pr are pointed at integration where the detailed guides have been published.
https://trello.com/c/7bevQJP4/1497-investigate-options-to-hide-display-components-on-a-detailed-guide-page
https://trello.com/c/TaSxtjir/1540-build-custom-templates-for-brexit-child-taxon-pages