Remove unused pluralisation keys from locale files #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
remove-unused-plurals
branch
from
90720b0 to
e1f4216
Compare
In #2045, we updated the plural rules for each language that we support that is not included in the ruby-i18n gem (https://github.com/ruby-i18n/i18n/blob/master/test/test_data/locales/plurals.rb). This removes the keys that are no longer required in each language from their locale files.
brucebolt
force-pushed
the
remove-unused-plurals
branch
from
4ebaa9a to
31dfc2f
Compare
In these languages, there is no difference in the singular and plural forms of words, so Rails only uses the `other` value (according to the defined plural rules). Therefore removing the unused singular values.
brucebolt
force-pushed
the
remove-unused-plurals
branch
from
31dfc2f to
2a81e71
Compare
MuriloDalRi
approved these changes
Mar 18, 2021
1pretz1
added a commit
that referenced
this pull request
Apr 30, 2021
Missing keys autogenerated in the last commit didn't have appropriate pluralization keys for each language as they were simply copied from the base locale (en) - `one` & `other`. This commit adds or removes keys specific to the locale. Work to define each language's pluralization keys was [done prior][1] and so we could just copy the rules per set added. [1]: #2052
1pretz1
added a commit
that referenced
this pull request
May 11, 2021
Missing keys autogenerated in the last commit didn't have appropriate pluralization keys for each language as they were simply copied from the base locale (en) - `one` & `other`. This commit adds or removes keys specific to the locale. Work to define each language's pluralization keys was [done prior][1] and so we could just copy the rules per set added. [1]: #2052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2045, we updated the plural rules for each language that we support that is not included in the ruby-i18n gem.
This removes the keys that are no longer required in each language from their locale files.
Trello card: https://trello.com/c/lkVB57ri
I have not made any changes to
zh-hkandzh-twas there are problems with the translations, which will be addressed in https://trello.com/c/mbFPEn9h. Also not made any changes totras I believe the i18n rules for this could be wrong, so will write a card to look into this.