Amend plural rules for translations #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now in the i18n gem so we don't need to keep our own: https://github.com/ruby-i18n/i18n/blob/master/test/test_data/locales/plurals.rb
MuriloDalRi
force-pushed
the
amend-locale-plurals
branch
from
9ea2424 to
10fc4a9
Compare
MuriloDalRi
force-pushed
the
amend-locale-plurals
branch
from
10fc4a9 to
3cf7e33
Compare
MuriloDalRi
force-pushed
the
amend-locale-plurals
branch
from
3cf7e33 to
dd31abf
Compare
MuriloDalRi
force-pushed
the
amend-locale-plurals
branch
from
dd31abf to
4309fc9
Compare
MuriloDalRi
force-pushed
the
amend-locale-plurals
branch
from
4309fc9 to
7b2cf50
Compare
edwardkerry
reviewed
Mar 15, 2021
MuriloDalRi
force-pushed
the
amend-locale-plurals
branch
from
7b2cf50 to
0b826a6
Compare
edwardkerry
approved these changes
Mar 15, 2021
brucebolt
added a commit
that referenced
this pull request
Mar 17, 2021
In #2045, we updated the plural rules for each language that we support that is not included in the ruby-i18n gem (https://github.com/ruby-i18n/i18n/blob/master/test/test_data/locales/plurals.rb). This removes the keys that are no longer required in each language from their locale files.
brucebolt
added a commit
that referenced
this pull request
Mar 18, 2021
In #2045, we updated the plural rules for each language that we support that is not included in the ruby-i18n gem (https://github.com/ruby-i18n/i18n/blob/master/test/test_data/locales/plurals.rb). This removes the keys that are no longer required in each language from their locale files.
brucebolt
added a commit
that referenced
this pull request
Mar 18, 2021
In #2045, we updated the plural rules for each language that we support that is not included in the ruby-i18n gem (https://github.com/ruby-i18n/i18n/blob/master/test/test_data/locales/plurals.rb). This removes the keys that are no longer required in each language from their locale files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/eEphXlio/2394-5-check-and-update-rules-for-plural-forms-across-frontend-apps#comment-604a00ad005aeb703e5a5a86