Sort available_locales + consistently use symbols #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanGabbianelli
pushed a commit
to alphagov/whitehall
that referenced
this pull request
Dec 16, 2020
We already support `pa`, Punjabi Gurmukhi, a language used in Punjab, India. This is to add `pa-ur`, Punjabi Shahmukhi, a language used in Punjab, Pakistan, that uses the Urdu script. More information on the two languages can be found on this Wikipedia page: https://en.wikipedia.org/wiki/Punjabi_language The reason `pa-ur` was chosen as locale code is that `pa` is the language code for Punjabi and `ur` is the script subtag for Urdu. More information on this can be found on this Mozilla developer docs page: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Language_tag_syntax Docs followed: https://docs.publishing.service.gov.uk/manual/add-translation-whitehall.html Zendesk ticket: https://govuk.zendesk.com/agent/tickets/4371686 Related PRs: - alphagov/government-frontend#1942 Co-authored-by: Alan Gabbianelli <[email protected]> Co-authored-by: William Franklin <[email protected]>
AlanGabbianelli
pushed a commit
to alphagov/whitehall
that referenced
this pull request
Dec 16, 2020
We already support `pa`, Punjabi Gurmukhi, a language used in Punjab, India. This is to add `pa-ur`, Punjabi Shahmukhi, a language used in Punjab, Pakistan, that uses the Urdu script. More information on the two languages can be found on this Wikipedia page: https://en.wikipedia.org/wiki/Punjabi_language The reason `pa-ur` was chosen as locale code is that `pa` is the language code for Punjabi and `ur` is the script subtag for Urdu. More information on this can be found on this Mozilla developer docs page: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Language_tag_syntax Docs followed: https://docs.publishing.service.gov.uk/manual/add-translation-whitehall.html Zendesk ticket: https://govuk.zendesk.com/agent/tickets/4371686 Related PRs: - alphagov/government-frontend#1942 Co-authored-by: Alan Gabbianelli <[email protected]> Co-authored-by: William Franklin <[email protected]>
AlanGabbianelli
pushed a commit
to alphagov/govuk-content-schemas
that referenced
this pull request
Dec 16, 2020
We already support `pa`, Punjabi Gurmukhi, a language used in Punjab, India. This is to add `pa-ur`, Punjabi Shahmukhi, a language used in Punjab, Pakistan, that uses the Urdu script. More information on the two languages can be found on this Wikipedia page: https://en.wikipedia.org/wiki/Punjabi_language The reason `pa-ur` was chosen as locale code is that `pa` is the language code for Punjabi and `ur` is the script subtag for Urdu. More information on this can be found on this Mozilla developer docs page: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Language_tag_syntax Docs followed: https://docs.publishing.service.gov.uk/manual/add-translation-whitehall.html Zendesk ticket: https://govuk.zendesk.com/agent/tickets/4371686 Related PRs: - alphagov/whitehall#5915 - alphagov/government-frontend#1942
We already support `pa`, Punjabi Gurmukhi, a language used in Punjab, India. This is to add `pa-ur`, Punjabi Shahmukhi, a language used in Punjab, Pakistan, that uses the Urdu script. More information on the two languages can be found on this Wikipedia page: https://en.wikipedia.org/wiki/Punjabi_language The reason `pa-ur` was chosen as locale code is that `pa` is the language code for Punjabi and `ur` is the script subtag for Urdu. More information on this can be found on this Mozilla developer docs page: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Language_tag_syntax Docs followed: https://docs.publishing.service.gov.uk/manual/add-translation-whitehall.html Zendesk ticket: https://govuk.zendesk.com/agent/tickets/4371686 Related PRs: - alphagov/whitehall#5915 - https://github.com/alphagov/government-frontend/pull/1942/commits - alphagov/govuk-content-schemas#1034 - alphagov/content-store#791 - alphagov/publishing-api#1883
AlanGabbianelli
force-pushed
the
add-punjabi-shahmukhi-language
branch
from
d40ce1b to
653b02d
Compare
Tetrino
approved these changes
Dec 17, 2020
AlanGabbianelli
pushed a commit
to alphagov/govuk-content-schemas
that referenced
this pull request
Dec 17, 2020
We already support `pa`, Punjabi Gurmukhi, a language used in Punjab, India. This is to add `pa-ur`, Punjabi Shahmukhi, a language used in Punjab, Pakistan, that uses the Urdu script. More information on the two languages can be found on this Wikipedia page: https://en.wikipedia.org/wiki/Punjabi_language The reason `pa-ur` was chosen as locale code is that `pa` is the language code for Punjabi and `ur` is the script subtag for Urdu. More information on this can be found on this Mozilla developer docs page: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Language_tag_syntax Docs followed: https://docs.publishing.service.gov.uk/manual/add-translation-whitehall.html Zendesk ticket: https://govuk.zendesk.com/agent/tickets/4371686 Related PRs: - alphagov/whitehall#5915 - alphagov/government-frontend#1942 - #1034 - alphagov/content-store#791 - alphagov/publishing-api#1883
AlanGabbianelli
pushed a commit
to alphagov/govuk-content-schemas
that referenced
this pull request
Dec 17, 2020
We already support `pa`, Punjabi Gurmukhi, a language used in Punjab, India. This is to add `pa-ur`, Punjabi Shahmukhi, a language used in Punjab, Pakistan, that uses the Urdu script. More information on the two languages can be found on this Wikipedia page: https://en.wikipedia.org/wiki/Punjabi_language The reason `pa-ur` was chosen as locale code is that `pa` is the language code for Punjabi and `ur` is the script subtag for Urdu. More information on this can be found on this Mozilla developer docs page: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Language_tag_syntax Docs followed: https://docs.publishing.service.gov.uk/manual/add-translation-whitehall.html Zendesk ticket: https://govuk.zendesk.com/agent/tickets/4371686 Related PRs: - alphagov/whitehall#5915 - alphagov/government-frontend#1942 - #1034 - alphagov/content-store#791 - alphagov/publishing-api#1883
AlanGabbianelli
pushed a commit
to alphagov/govuk-content-schemas
that referenced
this pull request
Dec 17, 2020
We already support `pa`, Punjabi Gurmukhi, a language used in Punjab, India. This is to add `pa-ur`, Punjabi Shahmukhi, a language used in Punjab, Pakistan, that uses the Urdu script. More information on the two languages can be found on this Wikipedia page: https://en.wikipedia.org/wiki/Punjabi_language The reason `pa-ur` was chosen as locale code is that `pa` is the language code for Punjabi and `ur` is the script subtag for Urdu. More information on this can be found on this Mozilla developer docs page: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Language_tag_syntax Docs followed: https://docs.publishing.service.gov.uk/manual/add-translation-whitehall.html Zendesk ticket: https://govuk.zendesk.com/agent/tickets/4371686 Related PRs: - alphagov/whitehall#5915 - alphagov/government-frontend#1942 - #1034 - alphagov/content-store#791 - alphagov/publishing-api#1883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already support
pa, Punjabi Gurmukhi, a language used in Punjab, India. This is to addpa-ur, Punjabi Shahmukhi, a language used in Punjab, Pakistan, that uses the Urdu script.More information on the two languages can be found on this Wikipedia page: https://en.wikipedia.org/wiki/Punjabi_language
The reason
pa-urwas chosen as locale code is thatpais the language code for Punjabi anduris the script subtag for Urdu. More information on this can be found on this Mozilla developer docs page: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Language_tag_syntaxDocs followed: https://docs.publishing.service.gov.uk/manual/add-translation-whitehall.html
Zendesk ticket: https://govuk.zendesk.com/agent/tickets/4371686
Related PRs: