Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print link to detailed guides and HTML publications #1889

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

DilwoarH
Copy link
Contributor

@DilwoarH DilwoarH commented Oct 27, 2020

What

Adds print link to detailed guides and HTML publications

Why

User research found that users were not clear on how to print pages.

https://trello.com/c/zSFv4dxR/497-add-the-print-button-to-c19-pages-that-dont-have-it

Demo

Before

Top

Screenshot 2020-10-27 at 15 26 07

Bottom

Screenshot 2020-10-27 at 15 26 21

After

Top

Screenshot 2020-10-27 at 15 26 13

Bottom

Screenshot 2020-10-27 at 15 26 26


⚠️ This application is Continuously Deployed: ⚠️

  • Merged changes are automatically deployed to staging and production.

  • Make sure you follow the guidance for deployments before you merge.

  • Check your branch is being deployed in the Release app, after merging.

@bevanloon bevanloon temporarily deployed to government-f-add-print--e2mbxk October 27, 2020 15:25 Inactive
@DilwoarH
Copy link
Contributor Author

@andysellick @alex-ju - I have tagged you on this as we need to make sure that the breaking changes don't affect this app.

I haven't noticed anything but maybe worth clarifying

@alex-ju
Copy link
Contributor

alex-ju commented Oct 27, 2020

@andysellick @alex-ju - I have tagged you on this as we need to make sure that the breaking changes don't affect this app.

I haven't noticed anything but maybe worth clarifying

Looking at the changelog the only breaking change that affects this repo is the govspeak change.

Follow the example in the PR description to update govspeak before bumping the version.

@DilwoarH
Copy link
Contributor Author

Do not merge until work is done to update the version

@DilwoarH DilwoarH changed the title Add print link to detailed guides [Do not merge] Add print link to detailed guides Oct 27, 2020
@bevanloon bevanloon temporarily deployed to government-f-add-print--e2mbxk October 29, 2020 11:41 Inactive
@DilwoarH DilwoarH force-pushed the add-print-link-to-detailed-guides branch from 8805927 to d996eef Compare October 29, 2020 12:44
@bevanloon bevanloon temporarily deployed to government-f-add-print--e2mbxk October 29, 2020 12:45 Inactive
Dilwoar Hussain added 2 commits October 30, 2020 10:35
# What
Adds print link to detailed guides

# Why
User research found that users were not clear on how to print pages.

https://trello.com/c/zSFv4dxR/497-add-the-print-button-to-c19-pages-that-dont-have-it
@DilwoarH DilwoarH force-pushed the add-print-link-to-detailed-guides branch from d996eef to 1b4c3b9 Compare October 30, 2020 10:35
@bevanloon bevanloon temporarily deployed to government-f-add-print--e2mbxk October 30, 2020 10:35 Inactive
@DilwoarH
Copy link
Contributor Author

DilwoarH commented Oct 30, 2020

No longer blocked by #1884

@DilwoarH DilwoarH changed the title [Do not merge] Add print link to detailed guides Add print link to detailed guides Oct 30, 2020
@DilwoarH DilwoarH merged commit 7341f64 into master Oct 30, 2020
@DilwoarH DilwoarH deleted the add-print-link-to-detailed-guides branch October 30, 2020 10:47
@DilwoarH DilwoarH changed the title Add print link to detailed guides Add print link to detailed guides and HTML publications Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants