Update Govspeak usage #1884
Merged
Update Govspeak usage #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injms
force-pushed
the
update-govspeak-usage
branch
from
da2b2b9 to
f26ae87
Compare
injms
force-pushed
the
update-govspeak-usage
branch
from
f26ae87 to
06864eb
Compare
injms
force-pushed
the
update-govspeak-usage
branch
from
30839ed to
1b82283
Compare
injms
force-pushed
the
update-govspeak-usage
branch
from
1ffd246 to
b05ae00
Compare
injms
force-pushed
the
update-govspeak-usage
branch
6 times, most recently
from
424b4af to
6f0db61
Compare
maxgds
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
I've been relatively thorough going through examples of pages rendered by these templates to avoid another rollback like we had on manuals. It all seems good to me, with the proviso that I don't know how to check the /service_sign_in/ paths.
Edit to add: Have now also confirmed the sign in routes look fine.
I believe this is good to go.
The legacy attachment partial needed the `sanitize` method to be used with an allow list of attributes and tags.
injms
force-pushed
the
update-govspeak-usage
branch
from
6f0db61 to
ff5b3f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This updates the way Govspeak wraps content.
Templates updated:
Why
The previous method of adding content to Govspeak - using the
contentattribute - is being deprecated in favour of usingdoblocks with sanitized markup. See alphagov/govuk_publishing_components#1632 for more details.Visual changes
None.
Merged changes are automatically deployed to staging and production.
Make sure you follow the guidance for deployments before you merge.
Check your branch is being deployed in the Release app, after merging.