Upgrade to ruby 2.7.1 #1828
Merged
Upgrade to ruby 2.7.1 #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdccollins
force-pushed
the
upgrade-to-rails-6
branch
3 times, most recently
from
f1868cb to
2a1df0b
Compare
|
cdccollins
force-pushed
the
upgrade-to-ruby-2.7
branch
from
02f548c to
2ad4fa6
Compare
cdccollins
force-pushed
the
upgrade-to-ruby-2.7
branch
from
2ad4fa6 to
1c4aa37
Compare
Rhian
suggested changes
Sep 2, 2020
There was a problem hiding this comment.
I'd suggest the following tiny changes, based on our discussions earlier today:
- Revert the version bump in the .ruby-version and Dockerfile for now
- Ensure tests pass for 2.7.1 and update commit title to 2.7.1 from 2.7.0
- Fix spelling of 'deprecation' in commit title
cdccollins
force-pushed
the
upgrade-to-ruby-2.7
branch
4 times, most recently
from
7d7ef6d to
6b70e4e
Compare
cdccollins
force-pushed
the
upgrade-to-ruby-2.7
branch
from
6b70e4e to
b395bbc
Compare
Rhian
approved these changes
Sep 8, 2020
cdccollins
force-pushed
the
upgrade-to-ruby-2.7
branch
2 times, most recently
from
9e90104 to
d89943c
Compare
Splitting the last argument into positional and keyword parameters is deprecated
Ruby 2.7 shows a warning for this obsolete method, which has actually been obsolete for over 10 years now. This alternative method encodes `/` as well, so need to substitute those back in.
It's better to have the version of Ruby stored in just one place
cdccollins
force-pushed
the
upgrade-to-ruby-2.7
branch
from
d89943c to
bcd5de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes required to upgrade to ruby 2.7
There's a script that can be run to change the ruby version across all apps, so I've made the necessary changes for 2.7.1 but left the version as 2.6.6. However, the tests don't pass under ruby 2.6.6.
Visual regression results:
https://government-frontend-pr-1828.surge.sh/gallery.html
Merged changes are automatically deployed to staging and production.
Make sure you follow the guidance for deployments before you merge.
Check your branch is being deployed in the Release app, after merging.