Skip to content

Commit

Permalink
Remove gem "asset_bom_removal-rails"
Browse files Browse the repository at this point in the history
To work around the issue with sassc and unquote the accepted solution has been to
set css_compressor to nil and then use sass_style to achieve a similar effect.
However the gem forces the css_compressor back to :sass thus breaking again on asset compilation.

Removing the gem fixes this and the gem itself does not seem to be necessary since
it was introduced to fix issues in Firefox 52 and the latest Firefox version is
78
  • Loading branch information
cdccollins committed Aug 13, 2020
1 parent ce19f54 commit 2a1df0b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ ruby File.read(".ruby-version").strip

gem "rails", "6.0.3.2"

gem "asset_bom_removal-rails"
gem "dalli"
gem "gds-api-adapters"
gem "govuk_ab_testing"
Expand Down
4 changes: 0 additions & 4 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ GEM
ansi (1.5.0)
archive-zip (0.12.0)
io-like (~> 0.3.0)
asset_bom_removal-rails (1.0.2)
rails (>= 4.2)
sass (> 3.4)
ast (2.4.1)
better_errors (2.7.1)
coderay (>= 1.0.0)
Expand Down Expand Up @@ -371,7 +368,6 @@ PLATFORMS
ruby

DEPENDENCIES
asset_bom_removal-rails
better_errors
binding_of_caller
capybara
Expand Down

0 comments on commit 2a1df0b

Please sign in to comment.