Upgrade to rails 6 #1811
Merged
Upgrade to rails 6 #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
reviewed
Jul 7, 2020
cdccollins
force-pushed
the
upgrade-to-rails-6
branch
from
b4f1a0b to
4c008f1
Compare
pudiva
reviewed
Jul 9, 2020
cdccollins
force-pushed
the
upgrade-to-rails-6
branch
from
4c008f1 to
bbad063
Compare
cdccollins
force-pushed
the
upgrade-to-rails-6
branch
from
bbad063 to
5a322e1
Compare
cdccollins
force-pushed
the
upgrade-to-rails-6
branch
from
5a322e1 to
3548916
Compare
thomasleese
approved these changes
Jul 23, 2020
cdccollins
force-pushed
the
upgrade-to-rails-6
branch
3 times, most recently
from
8014b56 to
1455163
Compare
cdccollins
force-pushed
the
upgrade-to-rails-6
branch
from
6d9825c to
b8a3334
Compare
This was referenced Aug 11, 2020
pudiva
approved these changes
Aug 11, 2020
When running tests I was getting this error: `ActionView::Template::Error: undefined method `bubbles?' for true:Sass::Script::Tree::Literal` The solution is suggested here sds/scss-lint#278, specifically "You should only require scss-lint explicitly in your code so that the monkey patching code doesn't get loaded automatically. You can then explicitly load it for the cases where you need it" Putting it first in the rake tasks seems to stop it erroring as well.
Pin rails to specific version and make it stand out, see alphagov/service-manual-frontend@27390cd for reasoning.
cdccollins
force-pushed
the
upgrade-to-rails-6
branch
from
b8a3334 to
f1868cb
Compare
All the changes that come with Rails 6, mainly comments and minor config changes.
Custom alias domains such as http://government-frontend.dev.gov.uk are not working on any apps running Rails 6, due to the addition of "Host Authorisation" middleware so we need to explicitly add the local domain to their `config.hosts`. Similar PR: alphagov/info-frontend#644 Issue on govuk-docker: alphagov/support#687
According to testdouble/jasmine-rails#238 the jasmine-rails gem is no longer actively maintained and is reliant on the phantomjs headless browser which has suspended development (ariya/phantomjs#15344). Therefore it makes more sense to switch to the jasmine gem and use the jasmine_selenium_runner gem to switch to headless Chrome for testing.
Using a sass css compressor causes a scss file to be processed twice (once to build, once to compress) which breaks the usage of "unquote" to use CSS that has same function names as SCSS such as max.
To work around the issue with sassc and unquote the accepted solution has been to set css_compressor to nil and then use sass_style to achieve a similar effect. However the gem forces the css_compressor back to :sass thus breaking again on asset compilation. Removing the gem fixes this and the gem itself does not seem to be necessary since it was introduced to fix issues in Firefox 52 and the latest Firefox version is 78
cdccollins
force-pushed
the
upgrade-to-rails-6
branch
from
f1868cb to
2a1df0b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Rails 6, with minor config changes that come with it. Have also removed specified gem versions in Gemfile as it doesn't seem to cause any issues.
Merged changes are automatically deployed to staging and production.
Make sure you follow the guidance for deployments before you merge.
Check your branch is being deployed in the Release app, after merging.