Remove web_isbn and print_meta_data_contact_address #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanHallam
force-pushed
the
remove-redundant-fields
branch
from
4999755 to
c11927a
Compare
JonathanHallam
force-pushed
the
remove-redundant-fields
branch
from
c11927a to
f7d1fa4
Compare
Trello - https://trello.com/c/w5dsqKuc/1381-remove-redundant-fields-for-whitehall-attachments-org-contact-and-web-isbn These file types are redundant and should be removed. They are no longer being sent to the publishing api by whitehall
JonathanHallam
force-pushed
the
remove-redundant-fields
branch
from
f7d1fa4 to
04448ad
Compare
This was referenced Feb 10, 2020
benthorner
reviewed
Feb 11, 2020
| Any enquiries regarding this publication should be sent to us at:<br/> | ||
| </p> | ||
| <%= simple_format(@content_item.print_meta_data_contact_address) %> | ||
| <% end %> | ||
|
|
||
| <% unless @content_item.isbn.blank? %> | ||
| <p> | ||
| Print ISBN: <%= @content_item.isbn %> |
There was a problem hiding this comment.
It would make sense to remove Print here, although that would be a user-facing change. Perhaps raise in a separate PR, as it's confusing to see it used without context of knowing there used to be another ISBN.
There was a problem hiding this comment.
Yeah, good point, I'll raise a separate one after this :)
JonathanHallam
added a commit
that referenced
this pull request
Feb 11, 2020
Following #1649 Web ISBN has been removed. This left us with "Print ISBN" which sounds a bit odd if there are no other ISBN's. This renames "Print ISBN" to make things a bit clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello - https://trello.com/c/w5dsqKuc/1381-remove-redundant-fields-for-whitehall-attachments-org-contact-and-web-isbn
These file types are redundant and should be removed. They are no longer being sent to the publishing api by whitehall
These fields are also being removed from govuk content schemas and whitehall
whitehall - alphagov/whitehall#5333
content schemas - alphagov/govuk-content-schemas#958
Visual regression results:
https://government-frontend-pr-[THIS PR NUMBER].surge.sh/gallery.html