Skip to content

Commit

Permalink
Rename "Print ISBN" to "ISBN"
Browse files Browse the repository at this point in the history
Following #1649 Web ISBN has been removed. This left us with "Print ISBN" which sounds a bit odd if there are no other ISBN's. This renames "Print ISBN" to make things a bit clearer.
  • Loading branch information
JonathanHallam committed Feb 11, 2020
1 parent 5fc91a0 commit 223cd0a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@

<% unless @content_item.isbn.blank? %>
<p>
Print ISBN: <%= @content_item.isbn %>
ISBN: <%= @content_item.isbn %>
</p>
<% end %>
4 changes: 2 additions & 2 deletions test/integration/html_publication_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class HtmlPublicationTest < ActionDispatch::IntegrationTest
assert page.find(".print-meta-data", visible: false)

assert page.has_no_text?("© Crown copyright #{@content_item['details']['public_timestamp'].to_date.year}")
assert page.has_no_text?("Print ISBN: #{@content_item['details']['isbn']}")
assert page.has_no_text?("ISBN: #{@content_item['details']['isbn']}")
end
end

Expand All @@ -41,7 +41,7 @@ class HtmlPublicationTest < ActionDispatch::IntegrationTest
assert page.find(".print-meta-data", visible: true)

assert page.has_text?("© Crown copyright #{@content_item['details']['public_timestamp'].to_date.year}")
assert page.has_text?("Print ISBN: #{@content_item['details']['isbn']}")
assert page.has_text?("ISBN: #{@content_item['details']['isbn']}")
end
end

Expand Down

0 comments on commit 223cd0a

Please sign in to comment.