Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove govuk_frontend_toolkit dependency #1554

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Nov 26, 2019

What

Removes govuk_frontend_toolkit as a dependency, as it's not being used any more. The bulk of the work was already done by @andysellick in #1529

@bevanloon bevanloon temporarily deployed to government-frontend-pr-1554 November 26, 2019 11:31 Inactive
@vanitabarrett vanitabarrett marked this pull request as ready for review November 26, 2019 11:36
@vanitabarrett vanitabarrett changed the title Remove govuk-frontend-toolkit dependency Remove govuk_frontend_toolkit dependency Nov 26, 2019
Copy link
Contributor

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Checked the required assets and a few random pages.

@vanitabarrett vanitabarrett merged commit 4140c21 into master Nov 27, 2019
@vanitabarrett vanitabarrett deleted the remove-toolkit-dependency branch November 27, 2019 11:21
@andysellick
Copy link
Contributor

Wow that was all that needed doing? Amazing! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants