Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove govuk_frontend_toolkit sass dependency #1529

Merged
merged 8 commits into from
Nov 4, 2019
Merged

Remove govuk_frontend_toolkit sass dependency #1529

merged 8 commits into from
Nov 4, 2019

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Oct 28, 2019 •
edited
Loading

@bevanloon bevanloon temporarily deployed to government-frontend-pr-1529 October 28, 2019 12:36 Inactive
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1529 October 28, 2019 12:38 Inactive
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1529 October 28, 2019 12:40 Inactive
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1529 October 28, 2019 13:05 Inactive
@andysellick
Update misc toolkit references
a1acb59 
- change device pixel ratio mixin
- update organisation colours mixin
- use govuk-clearfix
@andysellick
Remove toolkit imports
e988581
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1529 October 28, 2019 13:10 Inactive
@andysellick andysellick marked this pull request as ready for review October 28, 2019 13:25
@andysellick andysellick changed the title [WIP] [DO NOT MERGE] Remove toolkit Remove govuk_frontend_toolkit sass dependency Oct 28, 2019
@andysellick andysellick requested review from maxgds, injms, vanitabarrett and alex-ju and removed request for maxgds and injms October 28, 2019 13:26
@andysellick andysellick merged commit 11dfc12 into master Nov 4, 2019
@andysellick andysellick deleted the remove-toolkit branch November 4, 2019 15:33
@vanitabarrett vanitabarrett mentioned this pull request Nov 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanitabarrett vanitabarrett vanitabarrett approved these changes

@maxgds maxgds Awaiting requested review from maxgds

@injms injms Awaiting requested review from injms

@alex-ju alex-ju Awaiting requested review from alex-ju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andysellick @vanitabarrett @bevanloon