Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch guides to emit faq structured data #1467

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Switch guides to emit faq structured data #1467

merged 2 commits into from
Sep 5, 2019

Conversation

sihugh
Copy link
Contributor

@sihugh sihugh commented Sep 5, 2019

This potentially gives us more control over the presentation of the result in external search applications.

Related to alphagov/govuk_publishing_components#1087

Component guide for this PR:
https://government-frontend-pr-1467.herokuapp.com/component-guide


I need to re-allow spidering (reverts part of #1461) in order to review structured data in checkers such as https://search.google.com/structured-data/testing-tool/u/0/ and https://search.google.com/test/rich-results

This only affects review apps as this robots.txt is not publicly accessible from production-like environments

We noindex, nofollow all the content pages in Heroku review apps, so I think we're safe to allow robots to access these pages.

This potentially gives us more control over the presentation of the result
in external search applications.

Related to alphagov/govuk_publishing_components#1087
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1467 September 5, 2019 14:36 Inactive
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1467 September 5, 2019 14:56 Inactive
I only put this in two days ago 🤦

I need this to be allowed in order to review structured data in checkers such
as https://search.google.com/structured-data/testing-tool/u/0/ and
https://search.google.com/test/rich-results

This only affects review apps as this robots.txt is not publicly accessible
from production-like environments

We noindex, nofollow all the content pages in Heroku review apps, so I think
we're safe to allow robots to access these pages.
@sihugh sihugh merged commit ea5820b into master Sep 5, 2019
@sihugh sihugh deleted the faqpages branch September 5, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants