Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban indexing in preview apps #1461

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Ban indexing in preview apps #1461

merged 1 commit into from
Sep 3, 2019

Conversation

sihugh
Copy link
Contributor

@sihugh sihugh commented Sep 3, 2019

Adds a noindex,nofollow to pages rendered using the application layout in
Heroku review apps.

Also disallows spiders from crawling this app using the robots.txt. The
robots.txt will only be accessible from apps that are not behind router.

This means that Heroku preview apps will indicate to crawlers that they should
not index the site, but applications in production environments will be unaffected.


Visual regression results:
https://government-frontend-pr-1461surge.sh/gallery.html

Component guide for this PR:
https://government-frontend-pr-1461.herokuapp.com/component-guide

@bevanloon bevanloon temporarily deployed to government-frontend-pr-1461 September 3, 2019 13:10 Inactive
@sihugh sihugh force-pushed the ban-indexing-in-preview-apps branch from 69f82c0 to ace9b95 Compare September 3, 2019 13:28
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1461 September 3, 2019 13:28 Inactive
Adds a noindex,nofollow to pages rendered using the application layout in
Heroku review apps.

Also disallows spiders from crawling this app using the robots.txt.  The
robots.txt will only be accessible from apps that are not behind router.

This means that Heroku preview apps will indicate to crawlers that they should
not index the site, but applications in production environments will be unaffected.
Copy link
Contributor

@barrucadu barrucadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the e2e failure is related to this change, and it LGTM

@sihugh sihugh merged commit 037c12b into master Sep 3, 2019
@sihugh sihugh deleted the ban-indexing-in-preview-apps branch September 3, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants