Don't show failed translation message for missing document types #1443
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the update to Whitehall that allows adding any GOV.UK page to a document collection there is the potential users could add documents with types the Government Frontend knows nothing about. For these cases this will return a nil value rather than raise a failed translation message. At this point in time it seems unlikely users would use a document type that is not known about as the expected usage is Content Publisher document types. However there is nothing to prevent wider usage of document types.
1pretz1
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/VdQtNZeV/1122-spike-making-content-publisher-documents-show-up-in-whitehall-document-collections
With the update to Whitehall that allows adding any GOV.UK page to a
document collection there is the potential users could add documents
with types the Government Frontend knows nothing about. For these cases
this will return a nil value rather than raise a failed translation
message.
At this point in time it seems unlikely users would use a document type
that is not known about as the expected usage is Content Publisher
document types. However there is nothing to prevent wider usage of
document types.
This resolves a situation like this:
Visual regression results:
https://government-frontend-pr-1443.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1443.herokuapp.com/component-guide