Merge pull request #1443 from alphagov/handle-missing-document-types

Don't show failed translation message for missing document types
alphagov · Aug 14, 2019 · 0b19af4 · 0b19af4
2 parents 3fa8b9e + 0d98a26
commit 0b19af4
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/app/presenters/document_collection_presenter.rb b/app/presenters/document_collection_presenter.rb
@@ -41,7 +41,9 @@ def group_document_links(group, group_index)
         },
         metadata: {
           public_updated_at: Time.zone.parse(link["public_updated_at"]),
-          document_type: I18n.t("content_item.schema_name.#{link['document_type']}", count: 1)
+          document_type: I18n.t("content_item.schema_name.#{link['document_type']}",
+                                count: 1,
+                                default: nil),
         },
       }
     end

diff --git a/test/presenters/document_collection_presenter_test.rb b/test/presenters/document_collection_presenter_test.rb
@@ -73,6 +73,21 @@ class PresentedDocumentCollection < TestCase
 
       assert_equal documents, presented_item.group_document_links({ "documents" => [document_ids.first] }, 0)
     end
+
+    test 'it handles the document type lacking a translation' do
+      schema_data = schema_item
+
+      document = schema_data["links"]["documents"].first.tap do |link|
+        link["document_type"] = "non-existant"
+      end
+
+      grouped = present_example(schema_data).group_document_links(
+        { "documents" => [document["content_id"]] },
+        0,
+      )
+
+      assert_nil grouped.first[:metadata][:document_type]
+    end
   end
 
   class GroupWithMissingDocument < TestCase