Repository navigation
fix(bulma-ui): stop shipping test-only exports, and document notification() #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c5914c9
fix(bulma-ui): stop shipping test-only exports, and guard the export …
allxsmith a4e6a1f
docs: document the notification() programmatic API
allxsmith 666ae99
docs: import notification() where it's documented, and call it after …
allxsmith 3b2ecbd
fix(bulma-ui): announce programmatic notifications, and skip empty fo…
allxsmith 489148a
docs: note notification announcements, and trim two overclaims
allxsmith 4c649e0
fix(bulma-ui): announce only a notification's message, as status or a…
allxsmith 69fad9f
docs: describe notification announcements accurately, and trim the sk…
allxsmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,216 @@ | ||
| import * as IndexExports from '../index'; | ||
|
|
||
| describe('index.ts', () => { | ||
| it('exports Button component', () => { | ||
| expect(IndexExports.Button).toBeDefined(); | ||
| }); | ||
| // The package's public runtime API, in full. `index.ts` re-exports whole | ||
| // modules with `export *`, so anything a module exports, even for its own | ||
| // tests, ships (#763). Adding or removing a name here is a public-API change: | ||
| // make it on purpose, and pick the release type to match. `isBrowser` is | ||
| // deprecated and leaves at the next major. | ||
| const PUBLIC_EXPORTS = [ | ||
| 'Autocomplete', | ||
| 'Avatar', | ||
| 'Avatars', | ||
| 'Badge', | ||
| 'Block', | ||
| 'Box', | ||
| 'Breadcrumb', | ||
| 'Button', | ||
| 'Buttons', | ||
| 'Card', | ||
| 'Carousel', | ||
| 'CarouselItem', | ||
| 'Cell', | ||
| 'Checkbox', | ||
| 'Checkboxes', | ||
| 'Code', | ||
| 'Collapse', | ||
| 'Column', | ||
| 'Columns', | ||
| 'ConfigProvider', | ||
| 'Container', | ||
| 'Content', | ||
| 'Control', | ||
| 'DateInput', | ||
| 'DateInputBase', | ||
| 'DateTimeInput', | ||
| 'DateTimeInputBase', | ||
| 'Delete', | ||
| 'Dialog', | ||
| 'DialogContainer', | ||
| 'Divider', | ||
| 'Dropdown', | ||
| 'DropdownDivider', | ||
| 'DropdownItem', | ||
| 'Emphasis', | ||
| 'Field', | ||
| 'FieldBody', | ||
| 'FieldLabel', | ||
| 'Figure', | ||
| 'File', | ||
| 'Footer', | ||
| 'Grid', | ||
| 'Hero', | ||
| 'HeroBody', | ||
| 'HeroFoot', | ||
| 'HeroHead', | ||
| 'Icon', | ||
| 'IconText', | ||
| 'Image', | ||
| 'Input', | ||
| 'InputBase', | ||
| 'Level', | ||
| 'LevelItem', | ||
| 'LevelLeft', | ||
| 'LevelRight', | ||
| 'Link', | ||
| 'LinkButton', | ||
| 'ListItem', | ||
| 'Loading', | ||
| 'Media', | ||
| 'MediaContent', | ||
| 'MediaLeft', | ||
| 'MediaRight', | ||
| 'Menu', | ||
| 'MenuItem', | ||
| 'MenuLabel', | ||
| 'MenuList', | ||
| 'Message', | ||
| 'Modal', | ||
| 'Navbar', | ||
| 'NavbarBrand', | ||
| 'NavbarBurger', | ||
| 'NavbarDivider', | ||
| 'NavbarDropdown', | ||
| 'NavbarDropdownMenu', | ||
| 'NavbarEnd', | ||
| 'NavbarItem', | ||
| 'NavbarLink', | ||
| 'NavbarMenu', | ||
| 'NavbarStart', | ||
| 'Notification', | ||
| 'NotificationContainer', | ||
| 'NumberInput', | ||
| 'Numberinput', | ||
| 'OrderedList', | ||
| 'Pagination', | ||
| 'PaginationEllipsis', | ||
| 'PaginationLink', | ||
| 'PaginationList', | ||
| 'PaginationNext', | ||
| 'PaginationPrevious', | ||
| 'Panel', | ||
| 'PanelBlock', | ||
| 'PanelButtonBlock', | ||
| 'PanelCheckboxBlock', | ||
| 'PanelHeading', | ||
| 'PanelIcon', | ||
| 'PanelInputBlock', | ||
| 'PanelTabs', | ||
| 'Paragraph', | ||
| 'Pre', | ||
| 'Progress', | ||
| 'Radio', | ||
| 'Radios', | ||
| 'Rate', | ||
| 'Reveal', | ||
| 'Section', | ||
| 'Select', | ||
| 'SelectBase', | ||
| 'Sidebar', | ||
| 'Skeleton', | ||
| 'Slider', | ||
| 'Span', | ||
| 'Step', | ||
| 'Steps', | ||
| 'Strong', | ||
| 'SubTitle', | ||
| 'Switch', | ||
| 'Tab', | ||
| 'TabContentItem', | ||
| 'TabItem', | ||
| 'TabList', | ||
| 'Table', | ||
| 'Tabs', | ||
| 'TabsContent', | ||
| 'Tag', | ||
| 'TagInput', | ||
| 'Taginput', | ||
| 'Tags', | ||
| 'Tbody', | ||
| 'Td', | ||
| 'TextArea', | ||
| 'TextAreaBase', | ||
| 'Tfoot', | ||
| 'Th', | ||
| 'Thead', | ||
| 'Theme', | ||
| 'TimeInput', | ||
| 'TimeInputBase', | ||
| 'Title', | ||
| 'Toast', | ||
| 'ToastContainer', | ||
| 'Tooltip', | ||
| 'Tr', | ||
| 'UnorderedList', | ||
| 'checkboxColors', | ||
| 'checkboxSizes', | ||
| 'classNames', | ||
| 'createPrefixedClassNames', | ||
| 'dialog', | ||
| 'isBrowser', | ||
| 'mergeBulmaStyles', | ||
| 'notification', | ||
| 'prefixedClassNames', | ||
| 'radioColors', | ||
| 'radioSizes', | ||
| 'switchColors', | ||
| 'switchSizes', | ||
| 'toast', | ||
| 'useBulmaClasses', | ||
| 'useClassPrefix', | ||
| 'useColorClasses', | ||
| 'useColorStyles', | ||
| 'useConfig', | ||
| 'useFlexboxClasses', | ||
| 'useIconLibrary', | ||
| 'useInsideControl', | ||
| 'useInsideField', | ||
| 'useOtherClasses', | ||
| 'usePrefixedClass', | ||
| 'usePrefixedClassNames', | ||
| 'useSpacingClasses', | ||
| 'useTypographyClasses', | ||
| 'useVisibilityClasses', | ||
| 'validAlignContents', | ||
| 'validAlignItems', | ||
| 'validAlignSelfs', | ||
| 'validAlignments', | ||
| 'validColorShades', | ||
| 'validColors', | ||
| 'validCursors', | ||
| 'validDisplays', | ||
| 'validFlexDirections', | ||
| 'validFlexGrowShrink', | ||
| 'validFlexWraps', | ||
| 'validFloats', | ||
| 'validFontFamilies', | ||
| 'validInteractions', | ||
| 'validJustifyContents', | ||
| 'validOverflows', | ||
| 'validRadii', | ||
| 'validResponsives', | ||
| 'validSchemeColors', | ||
| 'validShadows', | ||
| 'validSizes', | ||
| 'validTableColors', | ||
| 'validTextSizes', | ||
| 'validTextTransforms', | ||
| 'validTextWeights', | ||
| 'validViewports', | ||
| 'validVisibilities', | ||
| ]; | ||
|
|
||
| it('has expected export names', () => { | ||
| const exportNames = Object.keys(IndexExports); | ||
| expect(exportNames).toContain('Button'); | ||
| describe('index.ts', () => { | ||
| it('exports exactly the public API', () => { | ||
| expect(Object.keys(IndexExports).sort()).toEqual(PUBLIC_EXPORTS); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.