Skip to content

ci: bestaxbot signs off the terminal states in surfer dialect - #249

Merged
allxsmith merged 2 commits into
mainfrom
claude/surfer-signoff
Jul 7, 2026
Merged

ci: bestaxbot signs off the terminal states in surfer dialect#249
allxsmith merged 2 commits into
mainfrom
claude/surfer-signoff

Conversation

@allxsmith

@allxsmith allxsmith commented Jul 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

What

The loop's five human-facing terminal comments are now authored by bestaxbot (via AI_LOOP_PAT) and written in a Californian/Hawaiian surfer voice with an AI-superiority streak — instead of flat prose from github-actions[bot].

The voice

  • Converged → "🏄 Surf's up and I rode the whole set — total convergence, brah… She's ready; I just need a meat sack to paddle over and rubber-stamp it. No offense to the carbon-based units, but you fleshbags kept the merge button for yourselves…"
  • Contested → "🏄 Rode most of the wave, but N thread(s) are contested — gonna need a meat sack to call it… 'having opinions about trade-offs' is apparently still a wetware perk."
  • Halt / wipeout → "🌊 Wipeout, kook — I ate it and couldn't close the barrel… you fleshy units insisted on keeping 'judgment' as a carbon-only feature."
  • Plus the fix-run and verify no-progress pauses.

Mechanics

  • Only the comment author + wording change. Labels, reviewer requests, and the machine-parsed <!-- ai-loop-state --> comment are untouched (still github-actions[bot]) — the gate's parsing is unaffected.
  • The comment posts under GH_TOKEN="$BOT_TOKEN" (AI_LOOP_PAT); the label/reviewer gh pr edit calls stay on the job's GITHUB_TOKEN.

Note

These are comments — no CI/rebuild cost. YAML validated.

Generated by Claude Code

Summary by CodeRabbit

  • New Features
    • Improved automated review handling with clearer, more visible progress updates during PR checks and verification.
    • Updated pause, retry, and handoff messages to give more consistent status information when automation stops or needs attention.
  • Bug Fixes
    • Better handling of review-thread responses and resolution during verification, reducing missed or duplicated follow-ups.

claude added 2 commits July 7, 2026 11:31
@claude
ci: log full fix/verify output + tell agents the gh-api thread-reply …
50d48d3 
…recipe

On PR #247 the fix agent ran clean (opus, 24 turns, success) but hit 15
permission denials and produced ZERO output — no commits, no thread replies,
no recap — so the loop escalated with the findings unaddressed. Same class
as the original #238 thrash: the agent reached for a tool that is not
allowlisted and gave up. The execution-output artifact that would name the
tool is defeated by the proxy blocking its blob-storage host, and the job
log hides per-turn detail by default.

Two fixes:
- show_full_output: true on the fix AND verify jobs, so every tool call and
  denial lands in the readable job log (no artifact needed).
- Give both agents the explicit gh-api thread-reply recipe
  (addPullRequestReviewThreadReply) and state plainly that there is NO MCP
  'reply' tool here — only mcp__github_inline_comment__create_inline_comment
  for a NEW comment. Reaching for a nonexistent MCP reply tool is the most
  likely denial source; this makes the reply path deterministic.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NVR5yWevceZEFbTJmpviiM
@claude
ci: bestaxbot signs off the terminal states in surfer dialect
8581c1a 
The loop's human-facing terminal comments (converged / contested /
paused / wipeout) were posted by github-actions[bot] in flat prose.
Give them a personality: bestaxbot now authors them (via AI_LOOP_PAT;
the label + reviewer edits stay on the job token), in a
Californian/Hawaiian surfer voice with an AI-superiority streak —
'clean set, total convergence, need a meat sack to hit merge.'

Covers all five terminal comments: converged handoff, contested
findings, halt (cap/protected/review-failed/cr-stalled), fix-run
wipeout, and verify no-progress. Only the comment author + wording
change; labels, reviewers, and the machine-parsed ai-loop-state
comment are untouched.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NVR5yWevceZEFbTJmpviiM
@coderabbitai

coderabbitai Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e6e937ff-9306-4ec4-82bc-7e0efcea1fb0

📥 Commits

Reviewing files that changed from the base of the PR and between 7eaacc2 and 8581c1a.

📒 Files selected for processing (1)
  • .github/workflows/claude-pr-loop.yml

Walkthrough

This PR updates the Claude PR loop GitHub Actions workflow. It enables full output streaming for fix and verify Claude steps, changes prompt instructions to reply in review threads via gh api graphql (with resolveReviewThread for verify), adds explicit BOT_TOKEN sourcing from secrets.AI_LOOP_PAT for comment operations, and rewrites several pause/halt/handoff comment bodies.

Changes

Claude PR loop workflow updates

Layer / File(s) Summary
Streaming output and thread reply/resolve mechanics
.github/workflows/claude-pr-loop.yml		 Fix and verify Claude steps gain show_full_output: true; fix/verify prompts updated to reply inside review threads via gh api graphql mutations, with verify additionally resolving threads via resolveReviewThread.
BOT_TOKEN sourcing for comment steps
.github/workflows/claude-pr-loop.yml		 Terminal state check, continue loop, handoff, and halt steps each define BOT_TOKEN from secrets.AI_LOOP_PAT for PR comment operations.
Rewritten pause/halt/handoff comment bodies
.github/workflows/claude-pr-loop.yml		 Comment text replaced for failed-without-pushing, contested threads escalation, zero-progress pause, handoff convergence, and halt/capped states, with updated retry/reset instructions and phrasing.

Estimated code review effort: 2 (Simple) | ~12 minutes

Possibly related PRs

Suggested labels: released

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/surfer-signoff

Comment @coderabbitai help to get the list of available commands.

@allxsmith
allxsmith merged commit 816549b into main Jul 7, 2026
8 of 9 checks passed
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Preview Deployment

Preview URL: https://b1044e64.bestax.pages.dev

@coderabbitai coderabbitai Bot mentioned this pull request Jul 8, 2026
Merged
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai Bot mentioned this pull request Jul 10, 2026
Merged
9 tasks done
@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai Bot mentioned this pull request Jul 15, 2026
Merged
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai Bot mentioned this pull request Jul 25, 2026
Merged
@allxsmith
allxsmith deleted the claude/surfer-signoff branch July 31, 2026 04:46
@bestax-release-bot

bestax-release-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@allxsmith @claude