Skip to content

fix: pack_to_unchecked on big-endian targets #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaniPopes merged 1 commit into from
Aug 15, 2025
Merged

fix: pack_to_unchecked on big-endian targets #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flags: ["--no-default-features", "", "--all-features"]
flags: ["--no-default-features", "", "--all-features", "--target mips64-unknown-linux-gnuabi64"]
env:
MIRIFLAGS: -Zmiri-strict-provenance
steps:
Expand Down
3 changes: 2 additions & 1 deletion src/nibbles.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,8 @@ unsafe fn pack_to_unchecked(nibbles: &Nibbles, out: &mut [MaybeUninit<u8>]) {
let byte_len = nibbles.len().div_ceil(2);
debug_assert!(out.len() >= byte_len);
// Move source pointer to the end of the little endian slice
let mut src = as_le_slice(&nibbles.nibbles).as_ptr().add(U256::BYTES);
let sl = as_le_slice(&nibbles.nibbles);
let mut src = sl.as_ptr().add(U256::BYTES);
// Destination pointer is at the beginning of the output slice
let mut dst = out.as_mut_ptr().cast::<u8>();
// On each iteration, decrement the source pointer by one, set the destination byte, and
Expand Down