fix: pack_to_unchecked on big-endian targets#35
Merged
DaniPopes merged 1 commit intoalloy-rs:mainfrom Aug 15, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #35 will degrade performances by 20.92%Comparing Summary
Benchmarks breakdown
|
DaniPopes
reviewed
Aug 14, 2025
github-merge-queue bot
pushed a commit
to op-rs/kona
that referenced
this pull request
Aug 15, 2025
## Overview Adds a CI job to run `kona-client` on `cannon64`. Also upgrades the dep of `nybbles`; There was a bug that I introduced recently for big-endian targets, fix included in alloy-rs/nybbles#35. --------- Co-authored-by: refcell <abigger87@gmail.com>
matrix-rider609op
added a commit
to matrix-rider609op/kona
that referenced
this pull request
Sep 29, 2025
## Overview Adds a CI job to run `kona-client` on `cannon64`. Also upgrades the dep of `nybbles`; There was a bug that I introduced recently for big-endian targets, fix included in alloy-rs/nybbles#35. --------- Co-authored-by: refcell <abigger87@gmail.com>
aPTRDgvm5ui3dkEtFYWc
added a commit
to aPTRDgvm5ui3dkEtFYWc/kona
that referenced
this pull request
Oct 2, 2025
## Overview Adds a CI job to run `kona-client` on `cannon64`. Also upgrades the dep of `nybbles`; There was a bug that I introduced recently for big-endian targets, fix included in alloy-rs/nybbles#35. --------- Co-authored-by: refcell <abigger87@gmail.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Overview Adds a CI job to run `kona-client` on `cannon64`. Also upgrades the dep of `nybbles`; There was a bug that I introduced recently for big-endian targets, fix included in alloy-rs/nybbles#35. --------- Co-authored-by: refcell <abigger87@gmail.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
## Overview Adds a CI job to run `kona-client` on `cannon64`. Also upgrades the dep of `nybbles`; There was a bug that I introduced recently for big-endian targets, fix included in alloy-rs/nybbles#35. --------- Co-authored-by: refcell <abigger87@gmail.com>
edge-scripter8980
added a commit
to edge-scripter8980/kona
that referenced
this pull request
Feb 5, 2026
## Overview Adds a CI job to run `kona-client` on `cannon64`. Also upgrades the dep of `nybbles`; There was a bug that I introduced recently for big-endian targets, fix included in alloy-rs/nybbles#35. --------- Co-authored-by: refcell <abigger87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes an issue for big-endian targets that was introduced by #32, where the temporary value created by
as_le_slicewas dropped immediately after the expression is evaluated. This change extends the lifetime of theOwnedvariant.Repro (run miri): https://play.rust-lang.org/?version=stable&mode=release&edition=2024&gist=b92df156a14b6af538531bd8e3d28923