fix: r.as_ref() the trait AsRef<[_; 0]> is not implemented for [u8]#86
Merged
fix: r.as_ref() the trait AsRef<[_; 0]> is not implemented for [u8]#86
r.as_ref() the trait AsRef<[_; 0]> is not implemented for [u8]#86Conversation
Member
|
this is likely a msrv issue but we should use &* here changing |
mattsse
requested changes
May 12, 2025
| match context.local().shared_memory_buffer_slice(range.clone()) { | ||
| Some(slice) => { | ||
| r = slice; | ||
| r.as_ref() |
Member
There was a problem hiding this comment.
can we do &*r here instead, I believe this is how we solved htis in revm-inspectors
mattsse
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Whilst bumping to
alloy-evmv0.7.1 I encountered this issueThis only occurs when
alloy-evmis integrated (in this case Foundry); it is not raised when I clone and compilealloy-evmfrom sourceSolution
I think this code is equivalent and resolves the compiler error downstream for Foundry
cc @mattsse / @klkvr
PR Checklist