Skip to content

fix: r.as_ref() the trait AsRef<[_; 0]> is not implemented for [u8] #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 5 commits into from
May 12, 2025
Merged

fix: r.as_ref() the trait AsRef<[_; 0]> is not implemented for [u8] #86

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5c38a0
align op-revm
zerosnacks May 12, 2025
3770b7a
temp alt approach
zerosnacks May 12, 2025
af32b95
revert unintended op-revm bump
zerosnacks May 12, 2025
27bac5f
revert, use &*r instead of r.as_ref()
zerosnacks May 12, 2025
95f6a8a
remove unused import
zerosnacks May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/evm/src/precompiles.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ impl<CTX: ContextTr> PrecompileProvider<CTX> for PrecompilesMap {
match context.local().shared_memory_buffer_slice(range.clone()) {
Some(slice) => {
r = slice;
r.as_ref()
Copy link
Member

@mattsse mattsse May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do &*r here instead, I believe this is how we solved htis in revm-inspectors

paradigmxyz/revm-inspectors@5bf3f10

Copy link
Member Author

@zerosnacks zerosnacks May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this works 👍

Copy link
Member Author

@zerosnacks zerosnacks May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better 😄

&*r
}
None => &[],
}
Expand Down